JoergAtGithub
JoergAtGithub
And now I got the original again: ``` DEBUG ASSERT: "beatFraction > 0 && beatFraction < 1" in function bool __cdecl mixxx::Beats::findPrevNextBeats(class mixxx::audio::FramePos,class mixxx::audio::FramePos *,class mixxx::audio::FramePos *,bool) const at D:\mixxx-main-worktree\src\track\beats.cpp:460...
> **Con**: If you revert and try to load a track using a custom bar length, you will get an assert [here](https://github.com/mixxxdj/mixxx/pull/13330/files#diff-383b2cb6dca197a09c2ccc949329fa18cfb69d070c35e3af35cd8e0d48cd20bdR265). This will lead the grid being invalidated, same...
I tested again, and no asserts occured anymore! > > It's worth to highlight the invalidation would only happen if one: > > * Uses custom measure size in 2.6...
The markers in the waverforms are difficult to recognize. The visual representation in the original PR #2961 was more clear in my opinion: https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/beatgrid.20editing.20UI/near/206216183
I'm not familar with this part of the code. AFAIK @Holzhaus is the expert here.
Welcome at Mixxx! As a first-time contributor we need you to sign the [Mixxx Contributor Agreement](https://docs.google.com/forms/d/e/1FAIpQLScC9QG327sjLL0eWftmfGUasxFFLxg6LCXJ2xHDYRzFIRqyiw/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ) and comment here when you have done so. It gives us permission to distribute...
The pre-commit check is failing. The best way to fix pre-commit issues is to install pre-commit locally on your system, as described here: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking Than it will fix these issues...
> I would be interested in reviving this PR. Do you think it needs to be specific to Prime Go? While it's in general good, to prevent code duplication, this...
We have a topic about building on ARM based Macs in our Zulip chat: https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/Build.20on.20macOS.20ARM64 The GitHub CI builds cross compile the ARM executables on x64 build machines.
Please resolve the merge conflict, otherwise the CI builds will not start.