Exposed icon indicating copy to clipboard operation
Exposed copied to clipboard

Add support for datetime with timezone

Open alsofr opened this issue 5 years ago • 10 comments

Introduce a separate new datetimetz type

Existing datetime field was left untouched to avoid backward incompatibilities issues.

MySQL doesn't actually have support for the type so a dummy/incomplete implementation was done.

alsofr avatar Oct 24 '20 22:10 alsofr

HI there, I googled how to retrigger a new pipeline in Teamcity after adding a new commit to my existing pull request but it doesn't seem to work. The original build failed (but works locally) and I can't find any useful information in the logs (which database causes it to fail?). @Tapac is this possible or do I need to create a new pull request every time I have changes? Thanks in advance.

Early comments on the PR welcome as well.

alsofr avatar Oct 24 '20 23:10 alsofr

Hi @alsofr , the build will be triggered automatically after Teamcity will see your changes and free agent is available.

As I can see from the build log the ":exposed-java-time:test" task fails with Invalid zone offset pattern: +HH:mm:ss exception. You can try to run that task locally and check will it pass or not.

Tapac avatar Oct 25 '20 16:10 Tapac

Thanks for your answer, the build indeed retriggered, but several hours later.

I'm suspecting a difference between h2 running on mac osx vs linux because it works on my machine ™️ :).

alsofr avatar Oct 25 '20 19:10 alsofr

Hi again @Tapac , 12 hours later and still no build triggered for my 2 new commits. Is that expected?

alsofr avatar Oct 26 '20 08:10 alsofr

I've run build and reinstall GitHub webhook, I hope it will help.

Tapac avatar Oct 26 '20 09:10 Tapac

@Tapac the issue with TeamCity persists, the new commit doesn't trigger a new pipeline run in Teamcity.

alsofr avatar Nov 01 '20 09:11 alsofr

Hi there, a review would be appreciated. @Tapac maybe ?

alsofr avatar Nov 06 '20 08:11 alsofr

Hi again, sorry to insist but could i get a review on this code please? @Tapac ?

alsofr avatar Nov 19 '20 10:11 alsofr

HI @Tapac , any news about this PR? We really need more time support. Best Tim

tim-fdc avatar Jan 19 '21 14:01 tim-fdc

any update on this? why wasnt it merged? DateTime with TimeZone is really common feature @Tapac

dvorsky avatar Sep 16 '21 11:09 dvorsky

Hey @alsofr. Thank you for your contribution. This feature has now been implemented here #1787.

joc-a avatar Jul 27 '23 18:07 joc-a