Jeffrey Yu

Results 33 comments of Jeffrey Yu

Added a new commit and the tests now work in CI :)

> > Added a new commit and the tests now work in CI :) > > Great but you have removed some tests, like seeing the messages and stuff from...

@sidmohanty11 Any tools in mind? I'd recommend Cypress for e2e tests and json-server for mock APIs

Well there is only one example test...we do need to add more tests and some test coverage requirements This would be a large epic - we can divide it into...

> Yes @JeffreytheCoder that would be awesome! We can also go API by API and their related feature set first and then target a bit harder features like realtime communications...

@sidmohanty11 Do we need mock APIs for e2e tests? My understanding is that e2e tests should simulate as close to real-world usage as possible. Although the RC server is an...

Yes! @Spiral-Memory Let's do it together 🚀

Having mock APIs make our tests become integration tests, which also does the job since EC is just frontend. However, doing e2e tests means we don't have to create mock...

@Spiral-Memory Just saw your comment. Glad it's working for you :)

Thanks @VipinDevelops! I saw you created a `GitHubApi` instance for calling `getBasicUserInfo` in #144 . https://github.com/RocketChat/Apps.Github22/blob/109aae39cdd45850b3ea12ac885b790251546c5c/github/modals/UserProfileModal.ts#L49-L57 But in this way, everytime we need to call an API, we need to...