react-select icon indicating copy to clipboard operation
react-select copied to clipboard

Fix aria-activedescendant hydration mismatch error

Open brendanmorrell opened this issue 1 year ago • 2 comments

only allow aria-activedescendant prop to change based on client only variable after the component has mounted to prevent hydration mismatch. fixes this issue

brendanmorrell avatar Nov 07 '24 00:11 brendanmorrell

⚠️ No Changeset found

Latest commit: 5da82304faffef2f988b6960b393f9f2ffcf256e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Nov 07 '24 00:11 changeset-bot[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Nov 07 '24 00:11 codesandbox-ci[bot]

Is there a reason this issue was never fixed/merged?

flippidippi avatar Apr 02 '25 13:04 flippidippi

Can we merge this its really annoying

jrwpatterson avatar Apr 11 '25 01:04 jrwpatterson

pls merge this

tuke307 avatar Apr 17 '25 21:04 tuke307

@Methuselah96 Can you please review and confirm if this solution is viable?

vitalyiegorov avatar Apr 21 '25 17:04 vitalyiegorov

Just ran into this today after a fresh upgrade. looking forward to this one landing.

drusellers avatar May 17 '25 01:05 drusellers

+1

wirelessjeano avatar Jun 01 '25 06:06 wirelessjeano

I'm also running into this. Thanks for the fix; is there a timeframe for merging?

Brysonmk1984 avatar Jun 09 '25 14:06 Brysonmk1984

I like the fix in https://github.com/JedWatson/react-select/pull/5860 better, since it avoids an unnecessary re-render on non-Apple devices. Can someone recreate a new PR with those changes along with a changeset, and I will approve and merge?

Methuselah96 avatar Jun 09 '25 15:06 Methuselah96

please merge

wottpal avatar Jun 18 '25 22:06 wottpal

+1

wirelessjeano avatar Jun 19 '25 07:06 wirelessjeano

please merge

Please create a new PR based on https://github.com/JedWatson/react-select/pull/5860 :)

Methuselah96 avatar Jun 19 '25 11:06 Methuselah96

Here's the solution for now:

https://github.com/JedWatson/react-select/issues/5459#issuecomment-3010993879

erelcolak avatar Jun 27 '25 01:06 erelcolak

Superseded by https://github.com/JedWatson/react-select/pull/6051

Methuselah96 avatar Jul 11 '25 15:07 Methuselah96