Jc Miñarro comments

Results 40 comments of


                                            Jc Miñarro

After reacting on message, message list scrolls down to bottom

It has been fixed on #5280 and will be release in a new version in a couple of days

After reacting on message, message list scrolls down to bottom

Hello @dhaivat29 It has been already fixed and is available on the last release.

After reacting on message, message list scrolls down to bottom

Hello @dhaivat29 It looks like the reply by email to the Github Issue is not attaching all the info to the issue itself. Could you add the information on the...

Unit tests for DeveloperSettings should use mock of SharedPreferences

What do you think about to use a wrapper interface as a collaborator of `DeveloperSettings` instead of `SharedPreferences`?? With this collaborator you don't need to use `robolectirc` to test this...

Unit tests for DeveloperSettings should use mock of SharedPreferences

Ok, I will do a PR with that ;)

Unit tests for DeveloperSettings should use mock of SharedPreferences

@vanniktech It could be a good option. I am going to implement it on qualitymatters project and later I try to extract it on a library ;)

Unit tests for DeveloperSettings should use mock of SharedPreferences

We could use a `spy` to test it. On the other hand, why ther is different `assert` on the same test and they test something that is not described on...

When the giphy is the first message of the channel, it won't disappear when the user click cancel

Hello @allanswer We are investigating it and will fix it

The API are sending correct response but Android SDK is failing to give in succes callback.

Hello there. Thanks for reporting it. We are fixing it and will be ready soon.

The API are sending correct response but Android SDK is failing to give in succes callback.

@Yatish1910 @GrayaMax @lachlan-eagling A provisional fix has been done on #5257 But it looks like some changes in our backend, and they are fixing it as well to ensure any...