python-pdfkit icon indicating copy to clipboard operation
python-pdfkit copied to clipboard

Fix for issue #218

Open Klupamos opened this issue 3 years ago • 1 comments
trafficstars

Klupamos avatar Feb 22 '22 18:02 Klupamos

This could fix the issue as checking for python version too (https://stackoverflow.com/questions/19877306/nameerror-global-name-unicode-is-not-defined-in-python-3).

I hope you guys push the fix as it breaks python optimizer. This PR fixes issue #218 (error: NameError: name 'unicode' is not defined).

This error happens because Python v3 has replaced unicode with str. The problem is that if you use PYTHONOPTIMIZE then all asserts will be removed.

tomasserravento avatar Oct 25 '22 03:10 tomasserravento

Are you planning on merging this anytime soon?

ZordoC avatar Nov 30 '22 16:11 ZordoC

It would be amazing for this to get fixed but @JazzCore hasnt joined since november 2021 :(

I hope he is doing okay!

tomasserravento avatar Nov 30 '22 23:11 tomasserravento