xterm-player icon indicating copy to clipboard operation
xterm-player copied to clipboard

style suggestion

Open royl88 opened this issue 4 years ago • 0 comments

  1. i think change Icons.Pause to Icons.Play when state=="Paused" looks better. src/ui/PlayerView.ts
      case 'Paused':
        this._bigButton.style.display = 'block'
        // change icon
        this._bigButton.innerHTML = Icons.Play
        this._spinner.style.display = 'none'
        break
  1. better close rate-setting-box after changed rate src/ui/ControlBarView.ts
    addDisposableDomListener(this._playbackRate, 'click', () => {
      this._playbackRateSettingBox.classList.toggle('xp-setting-box-open')
    })
    this._playbackRateItems.forEach(item => {
      addDisposableDomListener(item, 'click', () => {
        this._player.playbackRate = parseFloat(item.dataset['rate'] || '1')
        // add this
        this._playbackRateSettingBox.classList.toggle('xp-setting-box-open')
      })
    })

royl88 avatar Feb 24 '21 10:02 royl88