ironbar icon indicating copy to clipboard operation
ironbar copied to clipboard

Published 20 hours ago • verified publisher icon JakeStanger

Support For Niri Workspaces

Open anant-357 opened this issue 1 year ago • 1 comments

Hi, please let me know if I've missed something. Resolves #650.

anant-357 avatar Sep 08 '24 17:09 anant-357

Appreciate the hard work here, big thanks for taking this on. Cheers YaLTeR for reviewing too, means a lot to see the actual dev provide input.

I'm a little busy at the moment so responses from me won't be as fast as I like, but ping me as soon as you need anything from me and I'll look as soon as I can. I'll give it a full review as soon as you're ready.

JakeStanger avatar Sep 11 '24 09:09 JakeStanger

Hi there! Thanks for the work, this PR is exactly what I need. Is there anything I can do to help move it forward?

calops avatar Nov 19 '24 10:11 calops

Hey, the following are outstanding:

  • [ ] Any unresolved comments here
  • [ ] Documentation updates
    • [ ] README - we now offer first-class support for Niri
    • [ ] Workspaces - module now supports Niri
  • [ ] Testing

If you're able to offer a hand with any of the above at all, that'd be great.

The plan is to ship 0.16.1 this weekend, assuming the tray doesn't find new ways to break before then. Once that's out, I'll merge this as soon as it's ready.

JakeStanger avatar Nov 19 '24 11:11 JakeStanger

There is an issue. If I remove a workspace from the middle, somehow when I move to another workspace, the focused workspace on the bar does not change. I am unable to pin point why this is happening. I also do not have multiple monitors, so it would be helpful if anyone could test for that.

anant-357 avatar Nov 19 '24 11:11 anant-357

I'd love to tackle these issues, but I don't know the best way to do it on a PR that comes from a fork that I don't own.

And for the comment about stress testing, I'm also not sure how to go about this.

calops avatar Nov 19 '24 12:11 calops

You may be able to open a PR on the fork, targeting the branch used for this PR. If that gets merged, it'll update here. If not you can just send a patch here.

Spamming the Niri IPC (aka a while true loop) with workspace changes and ensuring Ironbar can keep up is sufficient for stress testing.

JakeStanger avatar Nov 19 '24 13:11 JakeStanger

I'm closing in favour of #871, so I can rebase and continue development to get this across the line, as this being on the master branch with merge commits makes that difficult. You'll still be credited.

As it stands, that PR is identical to this one, albeit rebased onto the latest master commit and squashed.

JakeStanger avatar Feb 18 '25 22:02 JakeStanger