jabref icon indicating copy to clipboard operation
jabref copied to clipboard

Add "Home"-Button to entry-editor

Open hsvia opened this issue 3 years ago • 1 comments

When an entry is picked from the table of entries the entry-editor is positioned to this entry. When a group is selected, NOT containing this entry, the entry-editor keeps his position/content (what else...), there is NO highlighting in the table of entries any more (what else...).

When a (super-)group is highlighted, again containing the entry of the entry-editor, there is still NO highlighting in the table of entries. This should be improved, it is contra-intuitive The corresponding entry in the table of entries should be highlighted again.

A new button "Home" should be added to the in the entry-editor. It should force the selection of groups to walk the tree backwards until the group is containing this entry and the entry should be highlighted. Alternatively, the group should be switched to "All entries", in case walking the tree backwards is to costly.

This button allows for jumping back from a "search" in the groups, i.e a tentative switching between groups.

Best, HSvia

hsvia avatar Aug 30 '22 00:08 hsvia

Not sure if this specific button is really necessary.

When an entry is picked from the table of entries the entry-editor is positioned to this entry. :heavy_check_mark:

Good

When a group is selected, NOT containing this entry, the entry-editor keeps his position/content :heavy_check_mark:

Good

there is NO highlighting in the table of entries any more [when having selected a group NOT containing this entry] :heavy_check_mark:

Good

When a (super-)group is highlighted, again containing the entry of the entry-editor, there is still NO highlighting in the table of entries. :x:

Agree, there should be highlighting again.

In short: Whenever the entry, which is currently open in the entry editor is in the group, it should be highlighted.

If the highlighting were to work properly, clicking on the group "all entries" or alternatively a toggle for "show entries not in this group" (refs #9073), would provide the same outcome as implementing a "home" button - except for "jumping" to the selected entry. Workaround for the jumping would be to use the search bar and search for the entry.

ThiloteE avatar Aug 31 '22 22:08 ThiloteE

Can I contribute to this project. I have just learn java and want to begin to open source contribution if it is a beginner friendly project

nitesh-chowdhary avatar Oct 14 '22 13:10 nitesh-chowdhary

Yes, I think you can.

As a general advice for newcomers: check out https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md for a start. Also, https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace is worth having a look at. Feel free to ask if you have any questions here on GitHub or also at JabRef's Gitter chat.

Try to open a (draft) pull request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

Finally, I am not sure, if this issue will be affected, but soon some great changes will come to JabRef with the following pull-request: https://github.com/JabRef/jabref/pull/8963. Maybe there will be merge-conflicts, but I hope not.

In case of doubt, you probably should look for another good first issue, until the dust has settled.

ThiloteE avatar Oct 14 '22 14:10 ThiloteE

I think, this issue should be handled differently:

  • If a selection of JabRef leads to the fact that the entry of the entry editor is not in the table any more: Close the entry editor
  • If a selection of JabRef leads to the fact that the entry of the entry editor is shown again in the table: Reopen the entry editor

Selection of JabRef

  • Selection of a group
  • Search

Nevertheless, there should be a button "Focus". That button focuses the current entry in the entry table. Similar to IntelliJ's Alt+F1 and then Enter or Eclipse's sync button:

grafik

koppor avatar Oct 14 '22 20:10 koppor

Hi, my group plan to work on this issue and do it by the end of October 2022. This is our first issue on an open-source project. Could you assign this issue to me, please?

zeyu-gong avatar Oct 17 '22 04:10 zeyu-gong

@zeyu-gong @Thenitesh143 are you both in the same group?

ThiloteE avatar Oct 17 '22 09:10 ThiloteE

I'm no more working on this issue

nitesh-chowdhary avatar Oct 17 '22 15:10 nitesh-chowdhary

No, only me @ThiloteE

zeyu-gong avatar Oct 19 '22 06:10 zeyu-gong

Hi, my team would like to work on this issue. This is our first open issue in Github but we will try our best to imply and solve the problem. Could you please assign this issue to us?

William-Yao0993 avatar Oct 23 '22 13:10 William-Yao0993

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

github-actions[bot] avatar Oct 23 '22 13:10 github-actions[bot]

@William-Yao425 thank you for your interest and willingness to contribute. Of course you can try to solve this issue, but keep in mind that it is already reserved for @zeyu-gong and if the issue is solved before you can solve it, you might get into trouble with your university course (assuming you are a student group) and also, I think "first come, first serve" is good etiquette...

To be honest, sometimes I am a little bit confused why people seem to fight over very specific issues, such as this one. Already the third group trying to go for it. Have a look around JabRef's repo. There are many that are still free for the taking.

Please have a look at our projects page with "good first issues". If you are a student, the "candidates for university projects" page offers some issues of varying difficulty and scope and that have been estimated to be compatible with university courses as well and often bring a larger feature to JabRef. Of course, feel free to tackle one of the other "normal" issues around, if you feel you have the knowledge or the willingness to take them on.

Having said all that, at the end of the day, of course, you are the one free to choose what to work on and what feature you prefer JabRef to have. Such is the nature of open source software.

ThiloteE avatar Oct 23 '22 13:10 ThiloteE

I personally doubt that this is really a good first issue, since this will probably require some refactoring, as the issue is described you need to keep a history of every entry selected. This could grow really large.

calixtus avatar Oct 23 '22 15:10 calixtus

Thanks for your suggestion,@ThiloteE and @calixtus. We are indeed a Uni team, and we will find another good first issue through the repo. I apologize to @zeyu-gong that I did not realize the issue cannot be token by different group. Sincerely sorry about my rude manner. :)

William-Yao0993 avatar Oct 24 '22 01:10 William-Yao0993