jabref icon indicating copy to clipboard operation
jabref copied to clipboard
verified publisher icon JabRef

Implement escaping for keyword separators

Open koppor opened this issue 8 months ago • 31 comments

Context: https://github.com/JabRef/jabref/issues/12532#issuecomment-2743855961

JabRef does not support \ to be used as escaping for the keyword separator

Task:

  1. Add test cases for \, in org.jabref.model.entry.KeywordListTest
  2. Adapt org.jabref.model.entry.KeywordList#parse(java.lang.String, java.lang.Character, java.lang.Character) to implement parsing the escaping
  3. Adapt org.jabref.model.entry.KeywordList#serialize to escape properly

Please also keep in mind that the GUI renders differently than when serializing. This should be done if steps 2 and 3 were correctly done. -- You can double check with org.jabref.gui.fieldeditors.KeywordsEditorViewModel#serializeKeywords - and simply try out at the UI.

There was code proposed multiple times - but without any timely follow-up. Please ready through and implement a good solution

  • good test cases https://github.com/JabRef/jabref/pull/12888/files#diff-405010f9d24d966c1c8d319857c458e7a81761922448a5ff981e645d4ad43efc.
  • https://github.com/JabRef/jabref/pull/13583

When working on this address https://github.com/JabRef/jabref/pull/12888#discussion_r2030256080

koppor avatar Mar 23 '25 21:03 koppor

Hi, I am new to Opensource. I want to start my work on this. Can I work on this?

krishnagjsForGit avatar Mar 24 '25 02:03 krishnagjsForGit

/assign-me

krishnagjsForGit avatar Mar 24 '25 02:03 krishnagjsForGit

👋 Hey @krishnagjsForGit, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if there is not a (draft) pull request within 14 days (by 07 April 2025).

github-actions[bot] avatar Mar 24 '25 02:03 github-actions[bot]

Kindly Find the PR : https://github.com/krishnagjsForGit/jabref/pull/1

krishnagjsForGit avatar Apr 06 '25 02:04 krishnagjsForGit

I'm working on this issue. Please assign it to me. PR: #12810

Rajas55 avatar Apr 20 '25 22:04 Rajas55

⚠️ Issue Already Assigned

Hi @Rajas55, this issue is currently assigned to @krishnagjsForGit.

[!NOTE] If no progress is made within 14 days, the issue will be automatically unassigned.

Options for contributors
  • Wait for availability: The issue may become available if auto-unassigned
  • Collaborate: You can ask the assignee if they want help
  • Maintainer assistance: A maintainer can add you as co-assignee if appropriate

github-actions[bot] avatar Apr 20 '25 22:04 github-actions[bot]

PR opened to fix this in #12833. Please review when possible 🙂

Rajas55 avatar Apr 20 '25 22:04 Rajas55

PR opened to fix this in #12833. Please review when possible 🙂

Already issue is being worked upon. And PR review is on progress. Why duplicate the efforts?

krishnagjsForGit avatar Apr 22 '25 06:04 krishnagjsForGit

PR opened to fix this in #12833. Please review when possible 🙂

Wrong link. Please link the issue from the PR

koppor avatar Apr 22 '25 09:04 koppor

PR opened to fix this in #12833. Please review when possible 🙂

Wrong link. Please link the issue from the PR

koppor avatar Apr 22 '25 09:04 koppor

PR opened to fix this in #12833. Please review when possible 🙂

@Rajas55 Are you not able to read that someone else is assigned and working on this issue already?

subhramit avatar May 02 '25 09:05 subhramit

Hi! I'm a beginner in open source and Java, and I'd like to work on this issue as my first contribution. Can I take this up?

Harshavardhan-prog avatar May 06 '25 07:05 Harshavardhan-prog

Hi! I'm a beginner in open source and Java, and I'd like to work on this issue as my first contribution. Can I take this up?

Hi, welcome to JabRef. Unfortunately, @krishnagjsForGit is already assigned to the issue. You can check if an issue is assigned to somebody by looking at the right side column:

Image

You may pick any other first issue you like.

subhramit avatar May 06 '25 09:05 subhramit

I am new to this project, Can you assign me some task.

kirthi76 avatar Jun 16 '25 10:06 kirthi76

⚠️ Issue Already Assigned

Hi @kirthi76, this issue is currently assigned to @krishnagjsForGit.

[!NOTE] If no progress is made within 14 days, the issue will be automatically unassigned.

Options for contributors
  • Wait for availability: The issue may become available if auto-unassigned
  • Collaborate: You can ask the assignee if they want help
  • Maintainer assistance: A maintainer can add you as co-assignee if appropriate

github-actions[bot] avatar Jun 16 '25 10:06 github-actions[bot]

I saw the pr by @krishnagjsForGit just now. We should review it. @kirthi76 you can also review...

koppor avatar Jun 16 '25 11:06 koppor

Hi! this would be my first OpenSource Project, I would love to take on this one.

miguel-cordoba avatar Jul 12 '25 16:07 miguel-cordoba

/assign-me

miguel-cordoba avatar Jul 12 '25 16:07 miguel-cordoba

👋 Hey @miguel-cordoba, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

For questions on JabRef functionality and the code base, you can consult the JabRef Guru or ask on our Gitter chat.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

github-actions[bot] avatar Jul 12 '25 16:07 github-actions[bot]

⏰ Assignment Reminder

Hi @miguel-cordoba, this is a friendly reminder about your assignment to this issue.

[!WARNING] This issue will be automatically unassigned in 11 days if there's no activity.

Remember that you can ask the JabRef Guru or DeepWiki about anything regarding JabRef. Additionally, our contributing guide has hints on creating a pull request and a link to our Gitter chat.

How to keep your assignment


If you are working on it, you can prevent automatic unassignment by:

  • Submitting a draft pull request with your progress within 11 days
  • Asking for the 📌 Pinned label if you need more time

We appreciate your contribution and are here to help if needed!

github-actions[bot] avatar Jul 22 '25 12:07 github-actions[bot]

Hey I am Varun, a 2nd year engineering student familiar with the concepts of Java, OOP, Collections. I'd like to work on this issue as this will be my first contribution towards JabRef. Could you please assign it to me if it's still available ?

varun29sharma avatar Nov 09 '25 07:11 varun29sharma

⚠️ Issue Already Assigned

Hi @varun29sharma, this issue is currently assigned to @miguel-cordoba.

[!NOTE] This issue is pinned and will not be automatically unassigned.

Options for contributors
  • Collaborate: You can ask the assignee if they want help
  • Maintainer assistance: A maintainer can add you as co-assignee if appropriate
  • Wait for completion: The issue will remain assigned until the work is complete

github-actions[bot] avatar Nov 09 '25 07:11 github-actions[bot]