jabref icon indicating copy to clipboard operation
jabref copied to clipboard

user-specific file directory should show user name

Open koppor opened this issue 3 years ago β€’ 36 comments

image

It is unclear, which JabRef key is used there.

*Update

  • Show tooltip of username and host when hovering on "User-specific file directory" and the text box next to it
  • Also add a tooltip to LaTeX file directory

koppor avatar May 30 '22 12:05 koppor

Proposal: A however on the label "user-specific file directory" should show the username.

koppor avatar Jun 13 '22 21:06 koppor

Hi @koppor , Soft Eng intern here. I'd like to take a stab at this issue if it's possible. Thanks.

jackmcardle99 avatar May 21 '23 19:05 jackmcardle99

@jackmcardle99 I assigned you. Should be three lines of code.

koppor avatar Jun 06 '23 15:06 koppor

When reading https://github.com/JabRef/jabref/issues/9990, there should also be a proper tool tip on "LaTeX file directory". Maybe you can work on that too @jackmcardle99?

koppor avatar Jun 08 '23 13:06 koppor

Will get started on both issues this weekend @koppor

jackmcardle99 avatar Jun 08 '23 19:06 jackmcardle99

Hello, I'm a new contributor, and I will carefully read the contribution guidelines. Could you please assign this issue to me? @ThiloteE U6591996 W-10

JoleneSun111 avatar Oct 11 '23 12:10 JoleneSun111

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

ThiloteE avatar Oct 11 '23 13:10 ThiloteE

In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?

Username: This is the unique identifier of the user within the system. For instance, in the Windows operating system, the username could be "john_doe," while in the Linux operating system, it might be "jane_smith."

User's Home Directory: This is the main folder in the file system associated with the user, usually identified by their username. For instance, in the Windows operating system, the main directory might be "C:\Users\john_doe," whereas in the Linux operating system, it could be "/home/jane_smith."

Which of these should JabRef use to identify the user when they are not logged in? @koppor @ThiloteE Thank you so much for your help.

JoleneSun111 avatar Oct 21 '23 05:10 JoleneSun111

I do my change in Display_username branch, before my pull request, just wanna check if my change satisfy the issue's requirement: Now the username is displayed: image

I do several changes in the org.jabref.gui.libraryproperties.general. src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java: image org/jabref/gui/libraryproperties/general/GeneralProperties.fxml image src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesViewModel.java image

@koppor @ThiloteE

JoleneSun111 avatar Oct 21 '23 12:10 JoleneSun111

In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?

Username: This is the unique identifier of the user within the system. For instance, in the Windows operating system, the username could be "john_doe," while in the Linux operating system, it might be "jane_smith."

User's Home Directory: This is the main folder in the file system associated with the user, usually identified by their username. For instance, in the Windows operating system, the main directory might be "C:\Users\john_doe," whereas in the Linux operating system, it could be "/home/jane_smith."

Which of these should JabRef use to identify the user when they are not logged in? @koppor @ThiloteE Thank you so much for your help.

image

JoleneSun111 avatar Oct 21 '23 12:10 JoleneSun111

In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?

JabRef already handles this. It uses the log in user name of the current user. As you outlined, this is different from the laptop / PC / workstation / ... one uses.

The shown graphics looks like a debug version.

Please implement as follows:

Implement a hover on user-specific file directory. If the mouse is on hower, JabRef displays: user: {username}, host: {hostname}.

Please DO NOT modify the field content. This is the place, where the user configures their directory.

koppor avatar Oct 21 '23 16:10 koppor

589e2a9a049ace9deb4f7ab3096b275

This is the presentation of this pull request. I am still confused about the log in user, because even though I have read the documentation, I still cannot find where to log in JabRef.

In JabRef, when a user is not logged in, there's a need to retrieve the username from the operating system. However, which one should be used?

JabRef already handles this. It uses the log in user name of the current user. As you outlined, this is different from the laptop / PC / workstation / ... one uses.

The shown graphics looks like a debug version.

Please implement as follows:

Implement a hover on user-specific file directory. If the mouse is on hower, JabRef displays: user: {username}, host: {hostname}.

Please DO NOT modify the field content. This is the place, where the user configures their directory.

@koppor @ThiloteE

JoleneSun111 avatar Oct 22 '23 02:10 JoleneSun111

You cannot log in to JabRef, since JabRef is not a multi-user distributed application, but just a desktop application for the current os user to use. But multiple users are working with JabRef, every user has probably his own home directory. It is also not of importance, what username JabRef should use, if no user is logged in, because no user could use JabRef, when not logged in to a computer running JabRef. Still I don't get your question.

Please don't use the issue description to present screenshots of your code changes, but put this all into your Pull Request, since this clutters the issue discription with a lot of information that is about your PR and not about the original issue.

calixtus avatar Oct 22 '23 13:10 calixtus

There went sthg wrong, when i tried to resolve merge conflicts with in a PR, sorry for that.

calixtus avatar Oct 22 '23 13:10 calixtus

Hey @koppor , I am just a java enthusiast currently in my college, looking for some good issues to resolve, can you assign this issue to me?

saurabhhhcodes avatar Dec 29 '24 12:12 saurabhhhcodes

πŸ‘‹ Hey @8packcoder, it looks like you're interested in working on this issue! πŸŽ‰

If you'd like to take on this issue, please use the command /assign-me to assign yourself.

github-actions[bot] avatar Dec 29 '24 12:12 github-actions[bot]

/assign-me

saurabhhhcodes avatar Dec 30 '24 14:12 saurabhhhcodes

πŸ‘‹ Hey @8packcoder, thank you for your interest in this issue! πŸŽ‰

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! πŸš€

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 90 days (by 30 March 2025). A maintainer can also add the "πŸ“Œ Pinned"" label to prevent automatic unassignment.

github-actions[bot] avatar Dec 30 '24 14:12 github-actions[bot]

/assign-me

youssefgamal123 avatar Mar 08 '25 23:03 youssefgamal123

πŸ‘‹ Hey @youssefgamal123, thank you for your interest in this issue! πŸŽ‰

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! πŸš€

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 22 April 2025). A maintainer can also add the "πŸ“Œ Pinned"" label to prevent automatic unassignment.

github-actions[bot] avatar Mar 08 '25 23:03 github-actions[bot]

Hello @koppor ,

I have added the tooltip to show the username on hovering on User-specific file directory , can you please tell me what do you mean by host here in this context? , Do you mean the host of the current running machine?

Also, for the latex file directory tooltip , what should the tooltip display exactly?

Image

youssefgamal123 avatar Mar 09 '25 02:03 youssefgamal123

I have added the tooltip to show the username on hovering on User-specific file directory , can you please tell me what do you mean by host here in this context? , Do you mean the host of the current running machine?

Did you check existing code?

Please look for org.jabref.logic.FilePreferences#getUserAndHost

You can read at org.jabref.model.database.BibDatabaseContext#getFileDirectories how the directory is formed.

This information should be made transparent to the user.

Also, for the latex file directory tooltip , what should the tooltip display exactly?

Please try to be a software developer, not just a programmer. Think in options! Then you will maybe see yourself what is the best way.

PLEASE READ ALL THE COMMENTS IN THE ISSUE!!!!

See https://github.com/JabRef/jabref/issues/12269#issuecomment-2523109820

Implement a hover on user-specific file directory. If the mouse is on hower, JabRef displays: user: {username}, host: {hostname}.

koppor avatar Mar 11 '25 08:03 koppor

Hello there, i want to work on this issue, if this issue is still open please assign it to me. /assign-me Thank you!! Happy coding.

armycodes avatar Mar 12 '25 05:03 armycodes

πŸ‘‹ Hey @armycodes, looks like you’re eager to work on this issueβ€”great! πŸŽ‰ It also looks like you skipped reading our CONTRIBUTING.md, which explains exactly how to participate. No worries, it happens to the best of us. Give it a read, and you’ll discover the ancient wisdom of assigning issues to yourself. Trust me, it’s worth it. πŸš€

github-actions[bot] avatar Mar 12 '25 05:03 github-actions[bot]

/assign-me

armycodes avatar Mar 12 '25 05:03 armycodes

πŸ‘‹ Hey @armycodes, thank you for your interest in this issue! πŸŽ‰

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! πŸš€

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 26 April 2025). A maintainer can also add the "πŸ“Œ Pinned"" label to prevent automatic unassignment.

github-actions[bot] avatar Mar 12 '25 05:03 github-actions[bot]

πŸ“‹ Assignment Update

Hi @armycodes, due to inactivity, you have been unassigned from this issue.

Next steps


If you still want to work on this:

  • Submit a pull request showing your current state. You will be automatically assigned again.
  • Ask a maintainer to assign you again.

github-actions[bot] avatar Mar 27 '25 12:03 github-actions[bot]

/assign-me

ER812 avatar Apr 01 '25 13:04 ER812

πŸ‘‹ Hey @ER812, thank you for your interest in this issue! πŸŽ‰

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! πŸš€

github-actions[bot] avatar Apr 01 '25 13:04 github-actions[bot]

⏰ Assignment Reminder

Hi @ER812, this is a friendly reminder about your assignment to this issue.

[!WARNING] This issue will be automatically unassigned in 11 days if there's no activity.

How to keep your assignment


If you are working on it, you can prevent automatic unassignment by:

  • Submitting a draft PR with your progress
  • Asking for the πŸ“Œ Pinned label if you need more time

We appreciate your contribution and are here to help if needed!

github-actions[bot] avatar Apr 13 '25 12:04 github-actions[bot]