Jordan Cook

Results 195 comments of Jordan Cook

Good to know, thanks for tracking that down. It looks like this may be an unintended side effect of that bugfix rather than an intentional change, then. > It is...

That's right, the change you already made here: https://github.com/python-attrs/cattrs/blob/b1a681a60d07623618dfe440ac9c3ee6b9780307/pyproject.toml#L27 Works correctly for both pip and poetry.

I agree with the idea of using requests-cache here, although I'm a bit biased. :grin: It does support Redis, among several other backends. And I'd also agree that the best...

requests-cache works at the session level (`Session.send()`), not the adapter level, and also has an option for [excluding API tokens and other params](https://requests-cache.readthedocs.io/en/v0.7.3/user_guide.html#request-parameters).

This is a known issue with python>=3.10.2 and requests-cache

@barentsen I happen to be currently working on [requests-cache](https://github.com/reclosedev/requests-cache), which may be worth checking out as well. While it doesn't have the raw performance of diskcache, it might be more...

@tkrajina Any issues merging this in?

Yes, building and publishing docs would be automatic. It does require a hook for ReadTheDocs, but the rest is just code & config. After setup, there isn't much maintenance required....