JSqlParser icon indicating copy to clipboard operation
JSqlParser copied to clipboard

Published 20 hours ago • verified publisher icon JSQLParser

support clickhouse global keyword in join

Open julianzlzhang opened this issue 3 years ago • 2 comments

Support GLOBAL keyword for JOIN in ClickHouse.

julianzlzhang avatar Aug 16 '22 08:08 julianzlzhang

Looks good to me, please approve.

manticore-projects avatar Aug 16 '22 08:08 manticore-projects

JSqlParser enforces some coding rules you are violating in your PR. A complete maven build does not succeed in your branch. Please correct that.

Error:  src/main/java/net/sf/jsqlparser/statement/select/Join.java:[311,9] (whitespace) WhitespaceAfter: 'if' is not followed by whitespace.
Error:  src/main/java/net/sf/jsqlparser/util/deparser/SelectDeParser.java:[402,9] (whitespace) WhitespaceAfter: 'if' is not followed by whitespace.

wumpz avatar Aug 31 '22 20:08 wumpz

When will this problem be solved?

nettm avatar Nov 21 '22 06:11 nettm

@julianzlzhang When do you solve your PRs problems? Look into failing checkstyle verification.

wumpz avatar Nov 27 '22 15:11 wumpz

I have salvaged this PR into #1676

manticore-projects avatar Nov 28 '22 10:11 manticore-projects