ktlint-gradle icon indicating copy to clipboard operation
ktlint-gradle copied to clipboard

Published 20 hours ago • verified publisher icon JLLeitschuh

bump kotlin to 1.5.31, bump ktlint to 0.43.2

Open AleksanderBrzozowski opened this issue 3 years ago • 5 comments

Based on this, I decided to create a PR that would bump ktlint to newer version. Instead of trying to update to the newest version in one PR, I find it more convenient to split the update into more smaller parts.

Ktlint 0.43.2 requires at least kotlin 1.4 API. That's why I needed to change the minimum required gradle version to 6.8.

In next PR I would try to update gradle from 7.1.1 -> 7.2 :)

AleksanderBrzozowski avatar Jul 08 '22 19:07 AleksanderBrzozowski

@JLLeitschuh Could you review the PR? 🙏

AleksanderBrzozowski avatar Jul 12 '22 10:07 AleksanderBrzozowski

@JLLeitschuh up :)

AleksanderBrzozowski avatar Aug 01 '22 16:08 AleksanderBrzozowski

@JLLeitschuh Can you once again run the tests against windows? They failed with some strange error, I hope that its not related to the changes introduced in this PR :)

AleksanderBrzozowski avatar Aug 01 '22 20:08 AleksanderBrzozowski

It's not. Windows fail with an OOM error that I haven't figured out yet

JLLeitschuh avatar Aug 01 '22 21:08 JLLeitschuh

So, are we gonna merge this PR, even with failing windows build? ;)

AleksanderBrzozowski avatar Aug 02 '22 06:08 AleksanderBrzozowski

Thank you for your contribution. Sorry for taking so long. I've been super busy with Black Hat and DEFCON prepping as a speaker the past month.

JLLeitschuh avatar Aug 23 '22 15:08 JLLeitschuh