OpenJK icon indicating copy to clipboard operation
OpenJK copied to clipboard

Upgraded Windows Libraries - SDL2 > 2.0.13 FullscreenFix

Open Nightshades1 opened this issue 4 years ago • 6 comments

libjpeg 9a -> 9d zlib 1.2.8 -> 1.2.11 libpng 1.6.16 -> 1.6.37 SDL2 2.0.12 -> 2.0.16

Fixed fullscreen issue in recent SDL2 version 2.0.14 and above due to SDL_HINT_VIDEO_MINIMIZE_ON_FOCUS_LOSS being set to 0 by default.

Nightshades1 avatar Sep 10 '21 17:09 Nightshades1

Hi, is there a reason for not going the FULL mile?

libjpeg 9a -> 9e
zlib 1.2.8 -> 1.3
libpng 1.6.16 -> 1.6.40
OpenAL 0.9.9.5 -> 1.23.1
SDL2 2.0.12 -> 2.28.5

grafik

ArminiusTux avatar Dec 27 '23 20:12 ArminiusTux

Hi, is there a reason for not going the FULL mile?

libjpeg 9a -> 9e
zlib 1.2.8 -> 1.3
libpng 1.6.16 -> 1.6.40
OpenAL 0.9.9.5 -> 1.23.1
SDL2 2.0.12 -> 2.28.5

grafik

Did you have it working across Linux, Mac and WIndows? You should make a pull request for these changes.

taysta avatar Dec 28 '23 04:12 taysta

Upgrading OpenAL is ill advised because the included proprietary dll in the vanilla game isn't forward+backwards compatible. Iirc if you replace the newer version dll in the folder jamp/jasp will crash so you can't drop openjk in the same folder as the original and play openjk and original in the same install.

ensiform avatar Dec 28 '23 10:12 ensiform

Did you have it working across Linux, Mac and WIndows? You should make a pull request for these changes.

Point taken 😉

Upgrading OpenAL is ill advised because the included proprietary dll in the vanilla game isn't forward+backwards compatible. Iirc if you replace the newer version dll in the folder jamp/jasp will crash so you can't drop openjk in the same folder as the original and play openjk and original in the same install.

Interesting, so #1131 has to deal with the OpenAL situation as well then.

ArminiusTux avatar Dec 28 '23 21:12 ArminiusTux

Or don't support openal on arm at all. It's unsupported everywhere else, including x64 windows.

ensiform avatar Dec 29 '23 12:12 ensiform

Hi guys, i kept having notification on my mail 😁 I made that at the time i was playing Movie Battles II but it was generic to OpenJK anyway, i thought it was a good idea to upgrade the libraries.

Do note that when i sent that pull request, it was mostly only for Windows (the libraries upgrade), I can imagine that if you are on linux or even on windows, you would use cmake for it with a package manager (like the code we have to paste if we use vcpkg on Windows)

But if you plan to use Higher SDL Version, then don't forget about the "SDL_HINT_VIDEO_MINIMIZE_ON_FOCUS_LOSS" flag or you'll have issue with the fullscreen.

Nightshades1 avatar Dec 29 '23 19:12 Nightshades1