ivy-wallet icon indicating copy to clipboard operation
ivy-wallet copied to clipboard

[BUG] Incorrect Time Display and Account Balance Issue(critical issue)

Open asadmash opened this issue 1 year ago • 7 comments

Please confirm the following

Describe the bug

When adding a new entry, the entry time initially shows the current time, but after clicking 'Add,' it displays a time that is 6 hours earlier. Additionally, if the timing is changed manually, the entry reflects the correct time. However, the income, expenses, or transfer amounts do not update the account balance accordingly.

To Reproduce

  1. Add a new entry with the default time (current time).
  2. Click 'Add' to save the entry.
  3. Observe that the entry time now shows a time that is 6 hours earlier.
  4. Manually adjust the time of the entry.
  5. Observe that the entry now shows the correct time.
  6. Check the account balance to see if the income, expenses, or transfer amounts have been updated.

Expected behavior

The entry time should remain consistent with the current time unless manually changed.

The account balance should be correctly updated based on the income, expenses, or transfer amounts entered.

Screenshots

No response

App version

v2024.08.25(195) from play store & latest demo apk from TG.

Smartphone

symphony z40, android 10

Additional context

No response

asadmash avatar Aug 27 '24 08:08 asadmash

Thank you @asadmash for raising Issue #3434! 🚀 What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

ivywallet avatar Aug 27 '24 08:08 ivywallet

I'm on it

rodrigomatosc avatar Aug 28 '24 18:08 rodrigomatosc

⚠️ Hey @rodrigomatosc, this issue is not approved, yet. @ILIYANGERMANOV must approve it first.

Also, make sure to read our Contribution Guidelines.

ivywallet avatar Aug 28 '24 18:08 ivywallet

Appreciate. Hey @rodrigomatosc @shamim-emon I'm also working on the time problems in general. I'm trying to apply an app-wide fix. However, feel free to give these a shot - just heads up that we might have merge conflicts

ILIYANGERMANOV avatar Aug 28 '24 18:08 ILIYANGERMANOV

Appreciate. Hey @rodrigomatosc @shamim-emon I'm also working on the time problems in general. I'm trying to apply an app-wide fix. However, feel free to give these a shot - just heads up that we might have merge conflicts

Alright!

shamim-emon avatar Aug 28 '24 18:08 shamim-emon

Appreciate. Hey @rodrigomatosc @shamim-emon I'm also working on the time problems in general. I'm trying to apply an app-wide fix. However, feel free to give these a shot - just heads up that we might have merge conflicts

It'd be even better if we could split modules among ourselves? What do you say @ILIYANGERMANOV?

shamim-emon avatar Aug 28 '24 18:08 shamim-emon

Appreciate. Hey @rodrigomatosc @shamim-emon I'm also working on the time problems in general. I'm trying to apply an app-wide fix. However, feel free to give these a shot - just heads up that we might have merge conflicts

It'd be even better if we could split modules among ourselves? What do you say @ILIYANGERMANOV?

It's hard to split because you change one place to Instant the entire app wont' build :/ The change will propagate among all usages. I think to work a couple of hours today will make some buildable progress. if you want you can start building on top of it. Here's my PR: https://github.com/Ivy-Apps/ivy-wallet/pull/3435

I created the APIs that we should use across the app.

ILIYANGERMANOV avatar Aug 28 '24 19:08 ILIYANGERMANOV

Problem solved. Thanks to the developers and contributors.🤍

asadmash avatar Aug 30 '24 01:08 asadmash

When will the fix be merged so we can receive the update via Google Play Store?

5VPH3R avatar Aug 30 '24 06:08 5VPH3R

Problem solved. Thanks to the developers and contributors.🤍

Hello @asadmash The fix still didn't reach us on Google Play Store I'm still facing issues on GMT +3 Any ETA for getting the fix?

5VPH3R avatar Sep 01 '24 11:09 5VPH3R

Problem solved. Thanks to the developers and contributors.🤍

Hello @asadmash The fix still didn't reach us on Google Play Store I'm still facing issues on GMT +3 Any ETA for getting the fix?

It's on Google Play Beta, I'll promote it to prod and it'll be live when Google approves it

ILIYANGERMANOV avatar Sep 01 '24 12:09 ILIYANGERMANOV