ivy-wallet icon indicating copy to clipboard operation
ivy-wallet copied to clipboard

[Domain] Build the `AccountBalanceUseCase`

Open ILIYANGERMANOV opened this issue 1 year ago • 6 comments

Please confirm the following

What would you like to improve?

  • Build the AccountBalanceUseCase.
  • Use the AccountStatsUseCase and the TransactionRepository
class AccountBalanceUseCase @Inject constructor(...) {
   fun calculate(account: AccountId): Map<AssetCode, NonZeroDouble>
}
  • Build the NonZeroDouble following the pattern to the PositiveDouble
  • We neee NonZeroDouble to handle the case of negative balances (credits to @Vishwa-Raghavendra)

Because...

  • Proper domain logic following the architecture and having unit + property-based tests.

Description

No response

Success Criteria

  • Follows all dev guidelines (this is a critical code so expect Requests for changes on your PR)
  • Property-based tests
  • Unit tests

ILIYANGERMANOV avatar Apr 16 '24 17:04 ILIYANGERMANOV

Thank you @ILIYANGERMANOV for raising Issue #3143! 🚀 What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

ivywallet avatar Apr 16 '24 17:04 ivywallet

I'm on it

priyanshuborole avatar Apr 17 '24 12:04 priyanshuborole

"I'm on it"

priyanshuborole avatar Apr 17 '24 12:04 priyanshuborole

Thank you for your interest @priyanshuborole! 🎉 Issue #3143 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

ivywallet avatar Apr 17 '24 12:04 ivywallet

I'm on it

rishi2062 avatar Jun 11 '24 08:06 rishi2062

Thank you for your interest @rishi2062! 🎉 Issue #3143 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

ivywallet avatar Jun 11 '24 08:06 ivywallet

Hey @rishi2062 any updates on this? If not you can unassign yourself so someone else can take it

ILIYANGERMANOV avatar Jul 09 '24 22:07 ILIYANGERMANOV

Sure, although i started but not getting time lately.🥲

rishi2062 avatar Jul 17 '24 17:07 rishi2062

@ILIYANGERMANOV can you help me with the unassign code.

rishi2062 avatar Jul 17 '24 17:07 rishi2062

I'm on it

rodrigoliveirac avatar Aug 20 '24 17:08 rodrigoliveirac

Thank you for your interest @rodrigoliveirac! 🎉 Issue #3143 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

ivywallet avatar Aug 20 '24 17:08 ivywallet