ivy-wallet icon indicating copy to clipboard operation
ivy-wallet copied to clipboard

Widgets showing so many decimals

Open Karnamaharaja opened this issue 1 year ago • 15 comments

Please confirm the following

Describe the bug

When the total amount is above 1k rupees its fine like always but when the total amount is below 1k rupees along with some decimals (like 367.34) it adds up so many zeros

No response

Screenshots

Screenshot_2024-01-25-12-29-26-71_b783bf344239542886fee7b48fa4b892

Smartphone

realme 9 5G Speed Edition

Additional context

No response

Karnamaharaja avatar Jan 30 '24 05:01 Karnamaharaja

Thank you @Karnamaharaja for raising Issue #2904! 🚀 What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

ivywallet avatar Jan 30 '24 05:01 ivywallet

I'm on it

sandeepjak2007 avatar Feb 08 '24 18:02 sandeepjak2007

Thank you for your interest @sandeepjak2007! 🎉 Issue #2904 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

ivywallet avatar Feb 08 '24 18:02 ivywallet

I'm on it

Have made changes but have to test once. So Can you suggest to me the steps to run the wallet?

sandeepjak2007 avatar Feb 08 '24 18:02 sandeepjak2007

⚠️ Hey @sandeepjak2007, this issue is already taken by @sandeepjak2007. Do not start working on it! Please, pick another one.

Also, make sure to read our Contribution Guidelines.

ivywallet avatar Feb 08 '24 18:02 ivywallet

⚠️ Hey @sandeepjak2007, this issue is already taken by @sandeepjak2007. Do not start working on it! Please, pick another one.

Also, make sure to read our Contribution Guidelines.

Hey Bot, Two are the same 😄😄😄

sandeepjak2007 avatar Feb 08 '24 18:02 sandeepjak2007

@ILIYANGERMANOV @Karnamaharaja is this still reproducible? Or has this been fixed? I wasn't able to reproduce this issue on the latest pull

MAlini-Krishnan3 avatar Feb 27 '24 17:02 MAlini-Krishnan3

@ILIYANGERMANOV @Karnamaharaja is this still reproducible? Or has this been fixed? I wasn't able to reproduce this issue on the latest pull

It isn't, you were just lucky the Double to round without issues

ILIYANGERMANOV avatar Feb 27 '24 17:02 ILIYANGERMANOV

I wanted to work on it but i was also not able to reproduce it. Is it fixed?

DripYeager avatar Mar 15 '24 10:03 DripYeager

It's not fixed just harder to repro - formatting in the widget is still missing

ILIYANGERMANOV avatar Mar 15 '24 10:03 ILIYANGERMANOV

double.toString() = bug fix: DecimalFormat or better some Ivy formatting util

ILIYANGERMANOV avatar Mar 15 '24 10:03 ILIYANGERMANOV

I'm on it

DripYeager avatar Mar 16 '24 19:03 DripYeager

Thank you for your interest @DripYeager! 🎉 Issue #2904 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

ivywallet avatar Mar 16 '24 19:03 ivywallet

I have made the change, go through it once.

DripYeager avatar Mar 16 '24 19:03 DripYeager

I'd like to point out that I've also encountered this issue. From the looks of things, I guess this has been fixed an we're just waiting for a build to be uploaded to the Play Store. Screenshot_20240530-221049_One UI Home

idkwebdev avatar May 31 '24 02:05 idkwebdev

@ILIYANGERMANOV this can be closed as fix has already been merged.

suyash01 avatar Jul 06 '24 06:07 suyash01