ivy-wallet icon indicating copy to clipboard operation
ivy-wallet copied to clipboard

[BUG] Account Buttons Text Getting Squished

Open Psypher1 opened this issue 1 year ago • 27 comments

Please confirm the following

Describe the bug

Add Income and Add Expense buttons in the wallets don't render the text correctly. It's either cut out or makes the button look strange.

To Reproduce

  1. Create an account
  2. Add income/expense from that accound

Expected behavior

The buttons should look the same as the rest of the app Wallet

Screenshots

No response

Smartphone

Samsung Galaxy S10 Plus

Additional context

No response

Psypher1 avatar Dec 26 '23 07:12 Psypher1

Hey @Psypher1 i want to work on this, Please assign me this.

sebesti0n avatar Dec 31 '23 15:12 sebesti0n

Hey @Psypher1 i want to work on this, Please assign me this.

I don't think I have the permissions to assign people

Psypher1 avatar Dec 31 '23 21:12 Psypher1

okay

sebesti0n avatar Dec 31 '23 22:12 sebesti0n

@ILIYANGERMANOV please assign me this

sebesti0n avatar Dec 31 '23 22:12 sebesti0n

@sebesti0n say the "magic words" from CONTRIBUTING instructions in the repo, it's fully automated

ILIYANGERMANOV avatar Dec 31 '23 23:12 ILIYANGERMANOV

I'm on it

mokhtarmoustafa avatar Jan 01 '24 12:01 mokhtarmoustafa

Thank you for your interest @mokhtarmoustafa! 🎉 Issue #2851 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please unassign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

ivywallet avatar Jan 01 '24 12:01 ivywallet

Screenshot_20240101_144226 @Psypher1 what is the device that you used because everything is well from my side, look the attached image

mokhtarmoustafa avatar Jan 01 '24 12:01 mokhtarmoustafa

Screenshot_20240101_144226 @Psypher1 what is the device that you used because everything is well from my side, look the attached image

Samsung Galaxy S10 Plus

Psypher1 avatar Jan 04 '24 10:01 Psypher1

@ILIYANGERMANOV as this issue is device dependent, one solution might be to have an autoscaling text composable that fits in its container with the set padding.

Rick-AB avatar Feb 14 '24 17:02 Rick-AB

@ILIYANGERMANOV as this issue is device dependent, one solution might be to have an autoscaling text composable that fits in its container with the set padding.

We need to reduce paddings probably

ILIYANGERMANOV avatar Feb 14 '24 18:02 ILIYANGERMANOV

I'm on it

TanishMoral11 avatar Aug 06 '24 18:08 TanishMoral11

⚠️ Hey @TanishMoral11, this issue is already taken by @mokhtarmoustafa. Do not start working on it! Please, pick another one.

Also, make sure to read our Contribution Guidelines.

ivywallet avatar Aug 06 '24 18:08 ivywallet