Ivan Ribakov

Hi @fchimpan, any thoughts on the PR?

I'm interested in both UAC and UAS behaviours and I believe the UAS behaviour is a bit more involved. While this can probably be implemented externally I was wondering if...

> yes, but not on client,server. Fair enough. I think I for a second confused UAC/UAS with sipgo's Client and Server types. > This only is related to dialogs and...

Hi @williammartin, thanks for the pointer to the comment. Building the binary locally seems to have sorted out the issue for me. > However, it really seems like we should...

> There is already working solution Are you able to share any details? Is it open source? > part of other project I was mentioning to you You mean `diago`...

> Additionally, the last part about create / read / update / delete somehow reminds me of stateful testing - have you considered using that approach as well? Fair point....

Personally I'd be fine with search working on the original file/stream and highlighting being limited (for example highlighting entire entry if the match is found but not present in the...

Hi @miconda , thanks for your feedback! Regarding `ksr_logdata_t`, most likely it got flagged by some static checker, but we've re-tested the original version and couldn't pin-point which exact check/rule...

> Does it affect in any way the modules log_custom or log_systemd? It does not. Mentioned modules rely on the `_km_log_func` (set via `km_log_func_set`) while this patch uses `_km_custom_log_func` (set...

> Does it affect in any way the modules log_custom or log_systemd? Hi @miconda , did the above answer provide sufficient details for you? > it seems rather important change...