data-dex icon indicating copy to clipboard operation
data-dex copied to clipboard

Data Marshal loaded client side links are being blocked by Browser.

Open newbreedofgeek opened this issue 2 years ago • 4 comments

image

Current "View Data" logic talks to the Data Marshal and gets back the URL and then does this to open a new browser window with the link. https://github.com/Itheum/data-dex/blob/stg/src/DataNFT/MyDataNFTsMultiversX.tsx#L249

This method was used so that we can "stream out" data. i.e. it downloads the file if possible.

But this seems to appear as a popup blocked.

Need to work out another way to do it.

newbreedofgeek avatar Feb 27 '23 01:02 newbreedofgeek

Not possible to change the way the marshal streams out data via a popup.. so now we show a nice UI message to user to allow popups.

image

@fuzzyduke pls check and close

newbreedofgeek avatar Mar 06 '23 04:03 newbreedofgeek

@newbreedofgeek

The below is seen as expected during the process however, while the popup is blocked should the below continue to be seen with the user acknowledging via button click. Currently the message is seen for a brief period and then the popup disappears. image

image

fuzzyduke avatar Mar 07 '23 18:03 fuzzyduke

Clarifications I got from @fuzzyduke:

He means that the instruction screen regarding popups should stay on screen until the user allows popups or closes the window themselves rather than just staying on screen for X seconds.

@newbreedofgeek

damienen avatar Mar 15 '23 11:03 damienen

Unfortunately this wont be possible @fuzzyduke

  • at the moment, once the Data Marshal URL is loaded in a new tab, the progress model will close automatically. But this is fine as the data stream has loaded.
  • if the user has blocked the popups then it's a bit more complex as user needs to go into browser settings and unlock it.

Maybe what we can have is some extra text on the progress model that links out to a "Not seeing data FAQ" page on docs.itheum.io

Let's aim to do this and then close this ticket.

newbreedofgeek avatar Mar 15 '23 23:03 newbreedofgeek