iterable-android-sdk icon indicating copy to clipboard operation
iterable-android-sdk copied to clipboard

[MOB-4986] - Stop redraw listener on webview load

Open Ayyanchira opened this issue 3 years ago • 1 comments
trafficstars

🔹 Jira Ticket(s) if any

✏️ Description

onPreDraw() may keep getting called even after the inapp is being displayed and loaded completely. In some instance, getHeight() returns different values after the page has loaded which makes it go to the top. Hence stopping the continuous predraw calls and resizeScript calls after webview is loaded and visible. Might not be a perfect solution but looks like a temporary work around for current implementation.

Ayyanchira avatar Oct 19 '22 19:10 Ayyanchira

Codecov Report

Base: 62.35% // Head: 62.15% // Decreases project coverage by -0.19% :warning:

Coverage data is based on head (2e9cd0d) compared to base (9b16933). Patch coverage: 58.93% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   62.35%   62.15%   -0.20%     
==========================================
  Files          66       67       +1     
  Lines        3918     3924       +6     
  Branches      454      454              
==========================================
- Hits         2443     2439       -4     
- Misses       1235     1245      +10     
  Partials      240      240              
Impacted Files Coverage Δ
...ableapi/IterableInAppFragmentHTMLNotification.java 13.13% <0.00%> (-0.12%) :arrow_down:
...erable/iterableapi/IterableInAppMemoryStorage.java 56.25% <ø> (ø)
...terableapi/IterableNetworkConnectivityManager.java 33.33% <11.11%> (ø)
...ain/java/com/iterable/iterableapi/IterableApi.java 61.36% <59.50%> (ø)
...ava/com/iterable/iterableapi/IterableUtilImpl.java 63.63% <63.63%> (ø)
...iterable/iterableapi/IterableInAppFileStorage.java 80.00% <76.19%> (ø)
...in/java/com/iterable/iterableapi/IterableUtil.java 70.00% <100.00%> (-0.10%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 19 '22 20:10 codecov[bot]

Closing this PR. The issue is addressed adjusting other variable

Ayyanchira avatar Mar 31 '23 17:03 Ayyanchira