Issafalcon
Fixes stack overflow due to large test files
I was running into issues where one of our larger projects that has a massive test file was causing tests to not be able to run. Looking into the logs, it all seemed to stem from a stack overflow error due to the recursive nature of the post process method for XUnit. I was able to change it to not be a recursive function and everything works perfectly for me and loads fairly quick
I also had to change the proj_root to come from the solution instead of the cs project. This might break some behavior. Without this change, everything locked up and never loaded any tests
Thanks @waynebowie99 . I'll be looking into this as soon as I can. However, one thing I really need to do with this plugin is implement something like https://github.com/GustavEikaas/easy-dotnet.nvim/issues/74. I think it will solve a lot of outstanding issues with this adapter, and hopefully performance issues too.
I'll keep your PR on the back-burner though, as it may help once the widespread changes mentioned, have been made.
@waynebowie99 any plans to fix the CI tests failing? I am running into the same problem and it seems to have been abandoned.
@Dynge I abandoned this PR to help with #124 as that is the end goal. If you can provide assistance with that PR that would be greatly appreciated. Especially if you're ran into the same problem
@Dynge - This hasn't been abandoned as such. It's been put on hold in favour of #124 . This other PR aims to address a lot of outstanding edge cases that are just too many to address using the current tree sitter based implementation alone.
Once this overhaul is complete and has been thoroughly tested, performance can be reviewed again.
@Dynge I abandoned this PR to help with #124 as that is the end goal. If you can provide assistance with that PR that would be greatly appreciated. Especially if you're ran into the same problem
Ive made two PRs to your branch. Don't know if you've spotted them. 😃