neotest-dotnet icon indicating copy to clipboard operation
neotest-dotnet copied to clipboard

Test is indicated to be failed while the output logs test(s) to be successful.

Open NicolaiSattler opened this issue 1 year ago • 6 comments

I recently stumbled upon neotest for dotnet and I love how it works. Cheers for that :D

I did notice something strange: while running mstests in .net 8 for one or more tests, the process outputs a success result while the indicators tell it failed.

image

image

This is also the case inside of the summary panel.

my config:

require("neotest").setup({
  adapters = {
    require("neotest-dotnet")({
      discovery_root = "project"
    })
  },
})

Could the icon configuration be the cause of this?

NicolaiSattler avatar Oct 02 '24 18:10 NicolaiSattler

Hi @NicolaiSattler . Thanks for raising this. Life has gotten in the way of my side projects for a while, so just commenting here to say that this is an issue I'm aware of with MSTest (I've neglected this test runner a bit, as xUnit and NUnit are what I use mainy). However, https://github.com/GustavEikaas/easy-dotnet.nvim/issues/74 seems to be a solution to many problems with this plugin and the multiple test runners. I'll be looking into this ASAP.

Issafalcon avatar Oct 06 '24 10:10 Issafalcon

Hi @Issafalcon,

do you have any plans to work on this soon?

If I can support you, please let me know. Will try my best.

Eckii24 avatar Jan 29 '25 17:01 Eckii24

just ran into the exact same issue. all tests are marked as failed even tough they are all succeeding on the cli :) @Eckii24 have you found a workaround or how do you deal with this for the moment?

mdd-lipp avatar Apr 04 '25 08:04 mdd-lipp

Sorry for the delayed reply. @Eckii24, @NicolaiSattler, @mdd-lipp. All efforts are best being focused on an overhaul as part of #124 at the moment. It will catch all sorts of edge cases that the current implementation is just not equipped to deal with. Maintaining tree sitter queries that satisfy all the nuanced features of each test runner is not possible, so using Microsoft's underlying vstest platform architecture is the way forward.

Issafalcon avatar Apr 04 '25 13:04 Issafalcon

As an aside, I no longer have the time bandwidth to work on any open source at the moment, so I'm taking a back seat to others who have stepped up to help on #124.

Issafalcon avatar Apr 04 '25 13:04 Issafalcon

Hi @Issafalcon thank you very much for the update! Much appreciated.

mdd-lipp avatar Apr 04 '25 13:04 mdd-lipp