teams-for-linux icon indicating copy to clipboard operation
teams-for-linux copied to clipboard

Diacritics broken on file download

Open Templayer opened this issue 1 year ago • 28 comments

Describe the bug Using Teamsv2 - if I download a file from a team in Teams, the filename encoding breaks in Teams v2 (this didn't occur with v1). In the first printscreen - the right part is the file in the team, the left part is the resulting downloaded file in the file manager (Nemo).

Expected behavior Diacritics / character encoding should be preserved

Screenshots image

image

Desktop (please complete the following information):

  • OS: Linux Mint" 21.3 (Virginia) with Cinnamon GUI
  • Installation package: Debian
  • Version: 1.4.26

Templayer avatar Apr 15 '24 07:04 Templayer

May be not related to the app, but will investigate.

jijojosephk avatar Apr 15 '24 08:04 jijojosephk

Hi, Can you try if you get the same problem using a web browser ? Otherwise I think this one is an electron one and I would suggest to investigate in their issues to see if you find something there. https://github.com/electron/electron/issues . I do not think is related to the app, I am afraid.

IsmaelMartinez avatar May 02 '24 04:05 IsmaelMartinez

That is strange as we are using electron, that basically runs the core of Chrome under the hood (Chromium).

Can you check https://github.com/IsmaelMartinez/teams-for-linux/issues/357#issuecomment-632446994 and see if that does anything to you?

IsmaelMartinez avatar May 28 '24 05:05 IsmaelMartinez

I suspect is a electron issue. Can you try with version https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.4.33 ? That uses 30.0.1 electron version, that we had to revert, but maybe does solve that issue (it might have other problems). But I do suspect this is an electron issue and/or local configuration, and not a Teams-for-linux issue, but hopefully we can find a solution nevertheless.

IsmaelMartinez avatar May 28 '24 13:05 IsmaelMartinez

Sorry but I don't know how much we can help.

If you edit the issue and fill the template details with the logs and package information, that can give us more information.

Without them we are a bit blind tbh, and just guessing, but there are a lot of variables in play.

Having another guess I would check providing the LANG env variables. Maybe is using the wrong ones due to the desktop link you got or the package you are using.

Specially if you are using SNAP or Flatpak as their confinement CAN cause this sort of problems. We provide the app in many packaging systems for that reason.

IsmaelMartinez avatar May 28 '24 16:05 IsmaelMartinez

Sorry but still not clear what packaging system you are using. Debian can be in many ones (deb, snap, flatpak).

I would suspect is snap that is playing with your settings. You should be able to install it using apt like in the https://github.com/IsmaelMartinez/teams-for-linux?tab=readme-ov-file#debianubuntu-and-other-derivatives

Unfortunately I don't see anything on the logs, but I do suspect is snap that messing with the diacritics.

IsmaelMartinez avatar May 30 '24 08:05 IsmaelMartinez

I really don't know what else to look at. It might be an specific bug in the chromium version we use. I will try to update the electron version to 30.0.9 that uses Chromium to 124.0.6367.233 but I will release that as a pre-release 1st as we will be moving from 29.3.x to 30.0.x

IsmaelMartinez avatar Jun 05 '24 14:06 IsmaelMartinez

I am trying to do some work around that and release with the new electron in 1.7.0. I don't know when this will be ready but I will ping you in here to see if that solves this for you.

IsmaelMartinez avatar Jun 07 '24 10:06 IsmaelMartinez

Strange. I just copied that line you put in there as the name of an excel file, upload it, and downloaded fine (keep the same name). Do you have any colleague that can try the same file? Can you send an example file in here?

IsmaelMartinez avatar Jun 11 '24 05:06 IsmaelMartinez

I see, is when you are using one drive in within teams.

I cant' seem to be able to reproduce. I have tried with that file and many ways but still get the right text.

Maybe try to remove the one drive app and add it again?

IsmaelMartinez avatar Jun 15 '24 07:06 IsmaelMartinez

If you aren't the admin of your computer I would suggest reaching out to your administrator, updating them with the issue and bringing them to this issue channel. They might be able to help fix your issue.

Unfortunately, it is fairly difficult as I can't reproduce the issue from my end with the file and instructions you have given me, which makes me think that this is an os config issue.

Can you try copying the link to the file into a team chat and download it from there and see if you still have the same problem?

If you want to continue searching for the why, do reach out. Again, I am just trying to help here.

On Sat, 15 Jun 2024, 12:51 Templayer, @.***> wrote:

As a workaround, I will be using the browser version directly to download files for now, until (and if) it ever gets fixed.

— Reply to this email directly, view it on GitHub https://github.com/IsmaelMartinez/teams-for-linux/issues/1196#issuecomment-2169388055, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADJHEFAOKH5B3J6EUFWPPLZHQTEHAVCNFSM6AAAAABGGYK3OGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRZGM4DQMBVGU . You are receiving this because you commented.Message ID: @.***>

IsmaelMartinez avatar Jun 15 '24 15:06 IsmaelMartinez

Sorry, I don't know what else to try. I keep it open for a while in case someone else reports a similar problem and/or can think of other options. As mentioned, I can't reproduce the issue in my computer.

IsmaelMartinez avatar Jul 08 '24 08:07 IsmaelMartinez

maybe is related to https://github.com/electron/electron/issues/33662 ? If so, can you try the options in there and/or described in https://github.com/logseq/logseq/issues/9744 ? They might work.

IsmaelMartinez avatar Jul 14 '24 07:07 IsmaelMartinez

Have you tried with another gui, even if just to confirm is not around that area.

IsmaelMartinez avatar Jul 14 '24 18:07 IsmaelMartinez

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Oct 16 '24 08:10 github-actions[bot]

lovely, glad is working. It was probably unrelated to the app and a OS library update probably fixed it.

IsmaelMartinez avatar Oct 16 '24 11:10 IsmaelMartinez