teams-for-linux icon indicating copy to clipboard operation
teams-for-linux copied to clipboard

Add LanguageTool (a fantastic spelling and grammar checker)

Open emericv opened this issue 1 year ago • 2 comments

LanguageTool is a multilingual spelling, style, and grammar checker that helps correct or paraphrase texts.

On Chromium/Firefox an extension https://languagetool.org/ is available, and it can be integrated into this app.

emericv avatar Feb 20 '24 07:02 emericv

There's already a spell checker. Have you used it?

jijojosephk avatar Feb 21 '24 05:02 jijojosephk

@jijojosephk Yes, but the native spell checker is only a basic syntax-based spell checker. LanguageTool is really more powerful. It can :

  • dynamically autodetect the language.
  • perform grammar check
  • ... and other useful features

You can test the Firefox/Chrome browser extension :)

emericv avatar Feb 21 '24 09:02 emericv

@emericv Maintaining it will be difficult because it's only available as chrome extension.

jijojosephk avatar Mar 12 '24 06:03 jijojosephk

It has licensing. That can create problems in the future. We must see their license agreement.

jijojosephk avatar Mar 12 '24 07:03 jijojosephk

@emericv Maintaining it will be difficult because it's only available as chrome extension.

@jijojosephk I understand this.

I better idea is probably a generic way to add features like this as a plugin in all Electron-based applications…

emericv avatar Mar 12 '24 07:03 emericv

I had a look at adding support for plugging (like in chrome) but I didn't get far with it. Electron was limiting what sort of plugging you could connect a lot (in functionality and support). But that was a few electron versions ago.

If you or anyone have the time to have a look, that would be great.

On Tue, 12 Mar 2024, 07:55 Emeric Verschuur, @.***> wrote:

@emericv https://github.com/emericv Maintaining it will be difficult because it's only available as chrome extension.

@jijojosephk https://github.com/jijojosephk I understand this.

I better idea is probably a generic way to add features like this as a plugin in all Electron-based applications…

— Reply to this email directly, view it on GitHub https://github.com/IsmaelMartinez/teams-for-linux/issues/1113#issuecomment-1990978518, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADJHEANPDNBJ7DRTMOK24TYX2YHBAVCNFSM6AAAAABDQUWLVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJQHE3TQNJRHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

IsmaelMartinez avatar Mar 12 '24 07:03 IsmaelMartinez

@jijojosephk I found this : https://github.com/ramboxapp/electron-chrome-extensions

If I can add my extension manually to the Teams app, This solves my case :)

emericv avatar Mar 12 '24 08:03 emericv

That is the one I tried 1st but, as for their documentation "However, it only supports a subset of APIs with a focus on DevTools. Concepts like tabs, popups, and extension actions aren't known to Electron."

On Tue, 12 Mar 2024, 08:01 Emeric Verschuur, @.***> wrote:

@jijojosephk https://github.com/jijojosephk I found this : https://github.com/ramboxapp/electron-chrome-extensions

If I can add my extension manually to the Teams app, This solves my case :)

— Reply to this email directly, view it on GitHub https://github.com/IsmaelMartinez/teams-for-linux/issues/1113#issuecomment-1990986266, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADJHEA4P4VOMBHCD5UDJXTYX2Y4JAVCNFSM6AAAAABDQUWLVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJQHE4DMMRWGY . You are receiving this because you commented.Message ID: @.***>

IsmaelMartinez avatar Mar 12 '24 08:03 IsmaelMartinez

https://dev.languagetool.org/public-http-api

jijojosephk avatar Mar 12 '24 08:03 jijojosephk

JS library is not present. So only way is extension which is not fully supported in electron. @emericv I don't see this moving forward.

jijojosephk avatar Mar 12 '24 08:03 jijojosephk

@jijojosephk @IsmaelMartinez

I have opened an issue here : https://github.com/languagetool-org/languagetool/issues/10388

emericv avatar Mar 12 '24 08:03 emericv

closing and I will be following he issue in languagetool and re-open if required. Thanks for the suggestion and languagetool is a great tool

IsmaelMartinez avatar Apr 02 '24 22:04 IsmaelMartinez