AdvancedPeripherals icon indicating copy to clipboard operation
AdvancedPeripherals copied to clipboard

Added client test for the Chat Box peripheral

Open dogboy21 opened this issue 1 year ago • 1 comments

  • Please check if the PR fulfills these requirements
  • [x] The commit message are well described
  • [ ] Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. This is not mandatory
  • [x] All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

No tests for the Chat Box peripheral in #562

  • What is the new behavior (if this is a feature change)?

Added a test for the Chat Box with the new client test feature introduced in #622

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?)

No


ToDo:

  • [x] Implement tests for thechat event
  • [x] Fix the runTestClient and runGameTestClient gradle tasks
    • The runTestClient task is used to build the test structures, so it needs to have the property advancedperipheralstest.tags set to common,client so that both server and client tests can be built and executed.
    • The runGameTestClient is used to automatically run client tests, so the property advancedperipheralstest.tags needs to set to client so we only run the client tests, not the server tests.
    • With the current implementation this does not work correcly and both server and client tests are run on the client

dogboy21 avatar Jun 03 '24 10:06 dogboy21