AdvancedPeripherals icon indicating copy to clipboard operation
AdvancedPeripherals copied to clipboard

[Feature] add advanced place method to automata core when compass peripheral is equipped

Open zyxkad opened this issue 1 year ago • 8 comments

PLEASE READ THE GUIDELINES BEFORE MAKING A CONTRIBUTION

  • Please check if the PR fulfills these requirements
  • [x] The commit message are well described
  • [x] Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. This is not mandatory
  • [x] All changes have fully been tested
  • What kind of change does this PR introduce? (Bug fix, feature, ...) Feature & Bug fix

  • What is the current behavior? (You can also link to an open issue here) N/A Also going to fix

    • #599
  • What is the new behavior (if this is a feature change)? Now the compass turtle can place blocks around the turtle with specific facing, which makes 3D printer easier.

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?) No

  • Other information:

  • https://github.com/IntelligenceModding/Advanced-Peripherals-Documentation/pull/84

zyxkad avatar Apr 25 '24 00:04 zyxkad

I am not 100% if I like this. This adds world manipulation functions to the Compass Turtle, whereas the Meta Turtles should actually be used for this I know that the meta turtles currently don't have a place function Would it be a better idea to add the accurate place feature to the meta turtles IF the compass is attached? The main problem I see with that, that it would use one peripheral slot for these two added functions

The implementation of these features looks good, I don't see anything in it, I would change

SirEndii avatar Apr 29 '24 06:04 SirEndii

Would it be a better idea to add the accurate place feature to the meta turtles IF the compass is attached?

Good point, I'll try that

zyxkad avatar Apr 29 '24 14:04 zyxkad

However, can you review #597 first then? because merge two branch that changed same thing will be horrible

zyxkad avatar Apr 29 '24 14:04 zyxkad

Would it be a better idea to add the accurate place feature to the meta turtles IF the compass is attached? The main problem I see with that, that it would use one peripheral slot for these two added functions

Done

zyxkad avatar Apr 30 '24 21:04 zyxkad

I see some commits here Is this ready for review or a draft?

SirEndii avatar Apr 30 '24 22:04 SirEndii

Yeah I just added some comment, it's ready for review

zyxkad avatar Apr 30 '24 22:04 zyxkad

well I just noticed that forward is a verb, I should use front instead

zyxkad avatar Apr 30 '24 23:04 zyxkad

Ready for review again

zyxkad avatar May 01 '24 04:05 zyxkad