librealsense
librealsense copied to clipboard
Fix rs-logger device reset reconnect bug
@maloel do you feel this is still relevant?
@maloel do you feel this is still relevant?
I think it needs re-examining: much of this code has completely changed. I know of no current issue and this PR doesn't explain how to reproduce an issue.
Let's close unless @shlon can verify it's still relevant.
Hi I am not sure if you will are able to see my message since I am not longer under Librealsense area in github I was part of RealSense under Intel as an employee
If I recall correctly the issue was that if the logger is running and we reset the camera with ipex( that’s what we called it at the time) the logger does not recognize the camera again
Steps to reproduce
- Run only rs-logger as a standa lone and not the full librealsense suit
- Connect camera
- we see FW logs
- Reset the camera with ipex
- We do not see new FW logs * We should be able to see FW logs
Regards, Marwan Shlon
From: Eran @.> Sent: Tuesday, 4 June, 2024 12:00 To: IntelRealSense/librealsense @.> Cc: Marwan Shlon @.>; Mention @.> Subject: Re: [IntelRealSense/librealsense] Fix rs-logger device reset reconnect bug (#4691)
@maloelhttps://github.com/maloel do you feel this is still relevant?
I think it needs re-examining: much of this code has completely changed. I know of no current issue and this PR doesn't explain how to reproduce an issue.
Let's close unless @shlonhttps://github.com/shlon can verify it's still relevant.
— Reply to this email directly, view it on GitHubhttps://github.com/IntelRealSense/librealsense/pull/4691#issuecomment-2146986157, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGWOPOUEFFYQBKW5T6PGXPDZFV62DAVCNFSM4IOFZWVKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJUGY4TQNRRGU3Q. You are receiving this because you were mentioned.Message ID: @.@.>>
Close as the code base changed a lot since this PR Thanks for the contribution