librealsense icon indicating copy to clipboard operation
librealsense copied to clipboard

Add psl to libcurl linkage in external_libcurl.cmake

Open sebastianserna30 opened this issue 8 months ago • 3 comments
trafficstars

This PR fixes a build error in the librealsense project when compiling with CHECK_FOR_UPDATES=ON. As mentioned in #13724 . The issue arises during the linking phase of the realsense-viewer executable due to missing symbols from the Public Suffix List (PSL) library, which are required by the statically built libcurl library.

When CHECK_FOR_UPDATES is enabled, the build process fetches and builds libcurl as a static library. However, the linkage step fails because libcurl depends on libpsl (for PSL functionality), and the psl library was not explicitly linked in the CMake configuration. This results in undefined reference errors for PSL functions like psl_free, psl_latest, psl_builtin, and psl_is_cookie_domain_acceptable.

sebastianserna30 avatar Mar 13 '25 19:03 sebastianserna30

Can one of the admins verify this patch?

sysrsbuild avatar Mar 13 '25 19:03 sysrsbuild

@sebastianserna30 Hi Thanks for your PR I wonder if PSL is actually needed in our use case with curl. Maybe we can consider turning it off in the curl cmake?

this addition cause a regression in our GHA flows Especially in Ubuntu 24 and windows

Nir-Az avatar Mar 14 '25 12:03 Nir-Az

Hi @sebastianserna30 , any progress with this PR?

Nir-Az avatar Apr 30 '25 10:04 Nir-Az

Thanks for the PR, since #14315 was merged the new dependency is no longer required. Closing this PR

Nir-Az avatar Sep 30 '25 10:09 Nir-Az