librealsense icon indicating copy to clipboard operation
librealsense copied to clipboard

Add ARM NEON intrinsics to unpack_yuy2

Open fateshelled opened this issue 1 year ago • 2 comments
trafficstars

Changes:

  • adding unpack_yuy2_neon function
    • unpack yuy2 to y8, y16, rgb8, rgba8, bgr8 and bgra8 format.
    • tested on Ubuntu 22.04, OrangePi5 (RK3588s, 8GB of RAM) and RealSense D435.
  • adding early continue in align_images function
  • fix rs2_project_point_to_pixel and rs2_deproject_pixel_to_point function
    • change order of operations

fateshelled avatar Aug 16 '24 15:08 fateshelled

Can one of the admins verify this patch?

sysrsbuild avatar Aug 16 '24 15:08 sysrsbuild

I explained too little, my apologies. I added the optimization code for ARM CPUs because the CPU load was too large when using ARM CPUs. Please review if you like.

fateshelled avatar Aug 19 '24 23:08 fateshelled

Hi @fateshelled , Thanks for the PR, it will take some time but we will get to reviewing it. Maybe you can undo format changes to make the PR more readable? I see rs.cpp have format changes added..

Nir-Az avatar Aug 28 '24 20:08 Nir-Az

Hi @Nir-Az , Thanks for the reply. I fixed format changes. Please review it.

fateshelled avatar Aug 29 '24 15:08 fateshelled

It will take us some time to review and validate this PR on dedicated HW. I would suggest to split bug fixes and new features as we may merge 1 faster than the other :)

Nir-Az avatar Sep 03 '24 11:09 Nir-Az

Thanks for the reply. I have changed the request to a pull request for new features only.

fateshelled avatar Sep 03 '24 14:09 fateshelled

@fateshelled appreciate your contribution, we are always happy to integrate community pull requests :) Since this feature looks safe for regression and would benefit you and other users, I merged it based on your testing.

Thank you :)

Nir-Az avatar Sep 17 '24 12:09 Nir-Az

Thank you for merging the PR. I am very happy to contribute.

fateshelled avatar Sep 17 '24 13:09 fateshelled