librealsense
librealsense copied to clipboard
Add ARM NEON intrinsics to unpack_yuy2
Changes:
- adding
unpack_yuy2_neonfunction- unpack
yuy2toy8,y16,rgb8,rgba8,bgr8andbgra8format. - tested on Ubuntu 22.04, OrangePi5 (RK3588s, 8GB of RAM) and RealSense D435.
- unpack
- adding early continue in
align_imagesfunction - fix
rs2_project_point_to_pixelandrs2_deproject_pixel_to_pointfunction- change order of operations
Can one of the admins verify this patch?
I explained too little, my apologies. I added the optimization code for ARM CPUs because the CPU load was too large when using ARM CPUs. Please review if you like.
Hi @fateshelled , Thanks for the PR, it will take some time but we will get to reviewing it. Maybe you can undo format changes to make the PR more readable? I see rs.cpp have format changes added..
Hi @Nir-Az , Thanks for the reply. I fixed format changes. Please review it.
It will take us some time to review and validate this PR on dedicated HW. I would suggest to split bug fixes and new features as we may merge 1 faster than the other :)
Thanks for the reply. I have changed the request to a pull request for new features only.
@fateshelled appreciate your contribution, we are always happy to integrate community pull requests :) Since this feature looks safe for regression and would benefit you and other users, I merged it based on your testing.
Thank you :)
Thank you for merging the PR. I am very happy to contribute.