librealsense icon indicating copy to clipboard operation
librealsense copied to clipboard

Published 20 hours ago • verified publisher icon IntelRealSense

Pascal Headers

Open Blueicaro opened this issue 2 years ago • 6 comments
trafficstars

New pull request, after I deleted the other by error.

Blueicaro avatar Feb 08 '23 20:02 Blueicaro

Thanks @Blueicaro , We will soon review it and try it out!

Nir-Az avatar Feb 09 '23 13:02 Nir-Az

Hi @Blueicaro!

I have honored to be the first in our team who test your Pascal wrapper! It was a new experience for me and I successfully built the wrapper and run your examples. Thank you for your big efforts in the project!

We will happily point our users to your wrapper example (in your fork) for our community wrappers section, see: community-projects

We do have several comments that can help make this wrapper more professional, let's discuss them here in the PR and once we decide together it's OK we can update our docs, sounds fair?

Tamir91 avatar Mar 15 '23 11:03 Tamir91

Hello, I very happy if my work can help. Of course I will continue working on this project, following your sugestions. I don't have many experience working with git, also I don't have many experience working in this kind of project. I'm a industrial programer, and I started this project as a hobbie. So, tell me what I can do improve my work. I look forward to your comments

Blueicaro avatar Mar 20 '23 18:03 Blueicaro

Hi @Blueicaro! Nice! We think about a few tasks.

  1. Firstly, may you add a description of the build steps in the README? In other words, add a "Build examples" step to the "Table of content" in README.md and describe how to build examples with screenshots.
  2. May you write some information or readme file about example tools? What is their purpose and output, etc.?
  3. Please, change the file name from realsense.dll to realsense2.dll at the end of README.ms .
  4. We need to fix English typos in the README.ms

Thank you!

Tamir91 avatar Mar 23 '23 15:03 Tamir91

Hello, I made the taks. I have a question. Should I update my repository and do a new fork?, or just update my repository?. Thank you

Blueicaro avatar Mar 27 '23 08:03 Blueicaro

Hello, I made the taks. I have a question. Should I update my repository and do a new fork?, or just update my repository?. Thank you

Hi, You use your fork and push new commits with the changes.

Nir-Az avatar Mar 27 '23 08:03 Nir-Az