librealsense icon indicating copy to clipboard operation
librealsense copied to clipboard

Bash script made an incorrect string comparison

Open jcremona opened this issue 3 years ago • 0 comments

if [ "4.4" == PATCHES_REV ];

was replaced with:

if [ "4.4" = "$PATCHES_REV" ];

Missing $.

jcremona avatar Jun 29 '22 19:06 jcremona

Thanks for contribution! Please re-submit this PR to 'development' branch so we can merge it. @Nir-Az can you speedup and change PR branch?

dmipx avatar Sep 14 '22 12:09 dmipx

@jcremona Can you confirm testing this change on JP 4.4?

Nir-Az avatar Sep 14 '22 14:09 Nir-Az

@jcremona Can you confirm testing this change on JP 4.4?

I've tested on L4T version 32.2.1. When tested on this version, this script sets PATCHES_REV to 4.4. My Jetson TX2 has a JetPack 4.2.2.

jcremona avatar Sep 15 '22 17:09 jcremona

@jcremona Can you confirm testing this change on JP 4.4?

I've tested on L4T version 32.2.1. When tested on this version, this script sets PATCHES_REV to 4.4. My Jetson TX2 has a JetPack 4.2.2.

Great, thanks!

Nir-Az avatar Sep 15 '22 17:09 Nir-Az