LibCST
LibCST copied to clipboard
Instagram
Fix bug in MatchMapping class
This pull request fixes a bug in the MatchMapping class where a trailing comma was allowed without the presence of the **rest parameter. The bug was causing an error in the validation process. This PR ensures that a trailing comma is only allowed when the **rest parameter is present.
Reproduction:
import libcst as cst
cst.parse_module(r"""
match x:
case {
"a": a,
**rest,
}:
print(a)
""")
Hi @zrr1999!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.09%. Comparing base (
f8a9b80) to head (2377202). Report is 88 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1058 +/- ##
=======================================
Coverage 91.09% 91.09%
=======================================
Files 255 255
Lines 26564 26564
=======================================
Hits 24198 24198
Misses 2366 2366
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
