LibCST icon indicating copy to clipboard operation
LibCST copied to clipboard

Switch linting from ufmt+usort+flake8+black to Ruff

Open akx opened this issue 2 years ago • 1 comments

Summary

This PR switches the lint/format stack from ufmt+usort+flake8+black to Ruff.

I converted the Flake8 configuration with flake8-to-ruff, and adjusted it slightly to make reformatting and import sorting do as little as possible.

🤔 Hmm?

Looks like the codegen'd files have DOS file endings, so I had to unix2dos them after re-generating.

Test Plan

  1. See what CI says.
  2. See what LibCST maintainers say.

akx avatar Nov 27 '23 18:11 akx

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f8a9b80) 91.09% compared to head (bf9fc4c) 91.09%.

Files Patch % Lines
libcst/_parser/conversions/params.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files         255      255           
  Lines       26564    26564           
=======================================
  Hits        24198    24198           
  Misses       2366     2366           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 28 '23 07:11 codecov-commenter