IGListKit
IGListKit copied to clipboard
Fix incorrect publicHeaderPath in swift package
Changes in this pull request
- The swift package works static type by default, so i removes static type in product library.
- If target's path is changed, it must manually specify the
publicHeaderPath. I specifies thepublicHeaderPathproperty.
Checklist
- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [ ] I added an entry to the
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the contributing guide
Hi @OhKanghoon!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@TimOliver has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@OhKanghoon has updated the pull request. You must reimport the pull request before landing.
@TimOliver has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@TimOliver merged this pull request in Instagram/IGListKit@8380bb41616c6fac6a3860545163e17161c7bb6d.
Thanks so much @OhKanghoon! That was good to know!