IGListKit icon indicating copy to clipboard operation
IGListKit copied to clipboard

Published 20 hours ago • verified publisher icon Instagram

Fix test build error, remove unused headers.

Open dirtmelon opened this issue 4 years ago • 2 comments

Changes in this pull request

  1. Make IGListAdapterUpdaterCompatible.h public to fix test build error
  2. Remove unused headers to make code clean.

Checklist

  • [x] All tests pass. Demo project builds and runs.
  • [x] I added tests, an experiment, or detailed why my change isn't tested.
  • [ ] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • [x] I have reviewed the contributing guide

dirtmelon avatar Dec 20 '20 02:12 dirtmelon

Facebook Internal - Builds & Tests failed, but there is not enough information, could you please provide more information? @lorixx

dirtmelon avatar Feb 02 '21 13:02 dirtmelon

@dirtmelon has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Feb 19 '21 03:02 facebook-github-bot

Hi @dirtmelon! I'm so sorry for the delay for reviewing your PR. I'm going through all the PRs now to see which ones we should merge before shipping v5.0.

It looks like IGListKit has evolved to the point where most of these don't exist, and the tests all run properly now. I'm going to close this one off. Thanks again for your contribution!

TimOliver avatar Apr 26 '23 01:04 TimOliver