IGListKit icon indicating copy to clipboard operation
IGListKit copied to clipboard

Fixed version.sh

Open futuretap opened this issue 5 years ago • 2 comments

Changes in this pull request

Issue fixed: versions.sh script on macOS 10.5.3+

Checklist

  • [x] All tests pass. Demo project builds and runs.
  • [ ] I added tests, an experiment, or detailed why my change isn't tested.
  • [ ] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • [x] I have reviewed the contributing guide

futuretap avatar Nov 03 '20 17:11 futuretap

Hi @futuretap!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Nov 03 '20 17:11 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Nov 03 '20 17:11 facebook-github-bot

Hi @futuretap! Thanks for your PR! (And I've also used InAppSettingsKit in a personal project before, so thank you for that as well!)

I'm going through the PRs now to see which ones should be merged for v5.0. I'm not sure when it happened, but versions.sh has already been updated to your proposed changes.

Thanks again for your contribution! If you see any other places where the build scripts need updating, we'll try and merge your PR a bit faster next time.

TimOliver avatar Apr 26 '23 02:04 TimOliver