Provided support for iOS 13 Context Menus

[jeromeboursier]

Changes in this pull request

Issue fixed: Provided support for Context Menus

Checklist

• [x] All tests pass. Demo project builds and runs.
• [x] I added tests, an experiment, or detailed why my change isn't tested.
• [x] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
• [x] I have reviewed the contributing guide

[jeromeboursier]

Not sure about what to do with Travis failing, as per the following PR Fix the podlint error #1428 it seems it's a known issue.

[lorixx]

hey @jjbourdev , thanks for the PR! mind rebase from master and trigger the build again? thx!

[Flatout73]

Hey, what about merge?)

[jeromeboursier]

I wish I can :)

[amalenduk]

Hi, Any update on this

[facebook-github-bot]

@TimOliver has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@jeromeboursier has updated the pull request. You must reimport the pull request before landing.

[TimOliver]

Hi folks! I'm so sorry for the amount of time it's taken to get back to this PR. I had a play with the PR in the sample app, and I gotta say this is a pretty dope feature!

I tried importing it into the Instagram codebase, and after a bit of review, I think we need to tweak it a bit. Namely, that new method in IGListBindingSectionControllerSelectionDelegate implicitly adds UIKit as a required import for the protocol, which might have ramifications down the line.

We might need to have a think about this, but it might be more appropriate to add a new property/protocol to IGListBindingSectionController to handle context menu configurations in its own silo separate from cell configuration. This also gives us a better space to add more of the context menu protocol methods down the line.

What do you think?

[amalenduk]

Hi @TimOliver , Any update on this?