IGListKit icon indicating copy to clipboard operation
IGListKit copied to clipboard

Published 20 hours ago • verified publisher icon Instagram

Undefined symbols

Open RbBtSn0w opened this issue 5 years ago • 10 comments

Changes in this pull request

Issue fixed: #

Checklist

  • [x] All tests pass. Demo project builds and runs.
  • [ ] I added tests, an experiment, or detailed why my change isn't tested.
  • [ ] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • [x] I have reviewed the contributing guide

RbBtSn0w avatar Dec 16 '19 08:12 RbBtSn0w

Hi RbBtSn0w! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 16 '19 08:12 facebook-github-bot

Thanks Snow! It looks like CI still fails, do u mind look into it more?

lorixx avatar Dec 16 '19 19:12 lorixx

Thanks Snow! It looks like CI still fails, do u mind look into it more?

can you help me, restart build?

RbBtSn0w avatar Dec 17 '19 07:12 RbBtSn0w

@RbBtSn0w it looks like there are some merge conflicts. Could you fix the conflicts and update the PR? Thanks!

iperry90 avatar Jan 06 '20 15:01 iperry90

Automated benchmark results (pass #0): passed

concurrency: 32
requests per second: 6160
concurrency: 128
requests per second: 7641
concurrency: 512
requests per second: 4685
concurrency: 1024
requests per second: 4006

P1robot avatar Jan 24 '20 15:01 P1robot

Could u rebase onto the latest master and run "./script/setup.sh" again? Then request merge again, thanks!

lorixx avatar Feb 27 '20 01:02 lorixx

yes. rebase and update it.

by the way, if run "./script/setup.sh". here is fix commit at: https://github.com/Instagram/IGListKit/pull/1408

RbBtSn0w avatar Apr 16 '20 08:04 RbBtSn0w

@RbBtSn0w it looks like there are some merge conflicts. Could you fix the conflicts and update the PR? Thanks!

it's fixed of the conflicts.

RbBtSn0w avatar Apr 16 '20 08:04 RbBtSn0w

@RbBtSn0w if you're still looking to merge this, can you update with the CLA?

joetam avatar Oct 03 '20 03:10 joetam

@RbBtSn0w if you're still looking to merge this, can you update with the CLA?

what's about CLA?

RbBtSn0w avatar Oct 15 '20 07:10 RbBtSn0w

Hey folks! Sorry for not following up on this sooner. I recently did a pass on IGListKit's Xcode project to ensure all the source files were properly linked. This should be fine to close off now.

Thanks for the contribution, @RbBtSn0w!

TimOliver avatar Apr 26 '23 02:04 TimOliver