IGListKit icon indicating copy to clipboard operation
IGListKit copied to clipboard

Fix macOS 10.15 defaults cmd

Open RbBtSn0w opened this issue 5 years ago • 6 comments

Changes in this pull request

On macOS Catalina when pod install on Example. have an error at podspce file when run scrip "Version.sh"

defaults read is fail on macOS 10.15. not find Info

filepath  Domains may also be specified as a path to an arbitrary plist file, with or without the '.plist' extension. For example:

                 defaults read ~/Library/Containers/com.apple.TextEdit/Data/Library/Preferences/com.apple.TextEdit.plist

           normally gives the same result as the two previous examples.  In the following example:

                 defaults write ~/Desktop/TestFile foo bar

           will write the key 'foo' with the value 'bar' into the plist file 'TestFile.plist' that is on the user's desktop. If the file does not exist, it will
           be created. If it does exist, the key-value pair will be added, overwriting the value of 'foo' if it already existed.

           WARNING: The defaults command will be changed in an upcoming major release to only operate on preferences domains. General plist manipulation utili-
           ties will be folded into a different command-line program.

So update to other cmd. Use plutil Issue fixed: #

Checklist

  • [x] All tests pass. The demo project builds and runs.
  • [x] I added tests, an experiment, or detailed why my change isn't tested.
  • [x] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • [x] I have reviewed the contributing guide

RbBtSn0w avatar Dec 16 '19 07:12 RbBtSn0w

Hi RbBtSn0w! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 16 '19 07:12 facebook-github-bot

same issues case at : https://github.com/flutter/flutter/issues/33909

RbBtSn0w avatar Dec 16 '19 07:12 RbBtSn0w

Thanks for working on this! Looks like CI is still failing here, do u think it's related to your change?

lorixx avatar Dec 16 '19 19:12 lorixx

change No. the master branch still running fail. it's was testing on macOS 10.15.

plutil API is long-time service on macOS

RbBtSn0w avatar Dec 17 '19 07:12 RbBtSn0w

@RbBtSn0w Can you rebase onto master and update the PR again? Let's see if CI passed, I am happy to merge! Thanks again

lorixx avatar Mar 07 '20 06:03 lorixx

rebase and push it.

RbBtSn0w avatar Apr 16 '20 08:04 RbBtSn0w

Thanks for the PR! The build script was updated in the interim to resolve this issue, so we can close this one off now. :)

TimOliver avatar Apr 26 '23 06:04 TimOliver