Instabug-React-Native icon indicating copy to clipboard operation
Instabug-React-Native copied to clipboard

feat: add network spans feature flags

Open andrewdanieldev opened this issue 1 year ago • 3 comments

Description of the change

This PR contains the following changes:

  • Add new NetworkLogger module.
  • implement feature flags used to control native network interception.

Note: Certain network APIs have not been transferred to the NetworkLogger module to prevent merge conflicts. Additionally, some unit tests are missing and will be added separately.

Type of change

  • [ ] Bug fix (non-breaking change that fixes an issue)
  • [x] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: APM-20926

Checklists

Development

  • [x] Lint rules pass locally
  • [x] The code changed/added as part of this pull request has been covered with tests

Code review

  • [x] This pull request has a descriptive title and information useful to a reviewer
  • [x] Issue from task tracker has a link to this pull request

andrewdanieldev avatar Oct 16 '24 13:10 andrewdanieldev

The e2e and test_android tests are failing due to custom snapshots. Feel free to experiment with it locally.

andrewdanieldev avatar Oct 16 '24 14:10 andrewdanieldev

@ahmedAlaaInstabug @kholood-ea @a7medev I rebased the dev branch onto feat/network-spans and merged the changes from dev into the feat/network-spans-feature-flags branch.

andrewdanieldev avatar Oct 20 '24 14:10 andrewdanieldev

Warnings
:warning:

You have not included a CHANGELOG entry! You can find it at CHANGELOG.md.

Coverage Report

Label Coverage Status
JavaScript 96.6%
Android 51.1%
iOS 48.8%

Generated by :no_entry_sign: dangerJS against 2af4bdde96179215091785aa582187204c390a67

InstabugCI avatar Oct 21 '24 12:10 InstabugCI