itkwidgets icon indicating copy to clipboard operation
itkwidgets copied to clipboard

Fullscreen button does not work

Open PaulHax opened this issue 1 year ago • 3 comments

The fullscreen button does not work.
image

Works in https://github.com/InsightSoftwareConsortium/itk-viewer-bootstrap-ui

Probably need to add allow="fullscreen" to the iframe: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#allowfullscreen

PaulHax avatar Nov 18 '23 19:11 PaulHax

Given imjoy docs https://github.com/imjoy-team/ImJoy/blob/c255d9cda9dc19d441fb7cf1eaca806e5ec71af8/docs/development.md#permissions

I tried this: https://github.com/PaulHax/itkwidgets/commit/a796f037be4b2ce0332496d23f33c3618c5e04a6

But did not work. Maybe we can querySelector() in python for the iframe and set allow="fullscreen"?

PaulHax avatar Nov 19 '23 20:11 PaulHax

CC @bnmajor @oeway

thewtex avatar Nov 30 '23 20:11 thewtex

Hi I just checked, it appears that it's not possible to request fullscreen from within the iframe itself, the fullscreen should be done in the host window. This means we need to implement it in python as suggested by @PaulHax . And we might need to still add allow="fullscreen" to the iframe as I understand.

oeway avatar Nov 30 '23 21:11 oeway