ITKSoftwareGuide icon indicating copy to clipboard operation
ITKSoftwareGuide copied to clipboard

DOC: Appendices bookmarks not being generated

Open albert-github opened this issue 8 months ago • 5 comments

Adding appendices properly to bookmarks. Closes #128.

albert-github avatar Mar 25 '25 09:03 albert-github

This is how current PDF looks like for me: Screenshot 2025-03-25 08 35 26 What is this PR trying to change?

dzenanz avatar Mar 25 '25 12:03 dzenanz

Now I see #128. But I still see bookmarks (I think that's what the content in the left panel is): Screenshot 2025-03-25 08 40 24

dzenanz avatar Mar 25 '25 12:03 dzenanz

@dzenanz

I don't see the double appendices / Appendix in the propose patch anymore (see results in the GHA aritfacts: https://github.com/InsightSoftwareConsortium/ITKSoftwareGuide/actions/runs/14055782571)

I see with this commit: image

With the 5.4.2 version I see:

image

Note especially the place of the word appendices and the extra > in the new version, also when collapsing all high level parts we now see:

image

whilst in version 5.24.2 we see:

image

albert-github avatar Mar 25 '25 13:03 albert-github

Jon, could you please amend the commit with the message you would like to see? That could serve as another example for Albert to learn our preferred norms.

dzenanz avatar Mar 28 '25 14:03 dzenanz

Jon, could you please amend the commit with the message you would like to see? That could serve as another example for Albert to learn our preferred norms.

@dzenanz I've done this, but as I've not investigated the fix or possibilities, thoroughly, it is just guesswork or a mere description, so @albert-github I'd be grateful if you could amend the commit message.

Also, as it detaches from the commit message that I put, there is not a single command there that says explicitly which ones makes the bookmarks to be displayed, which should be the whole point of the fix.

jhlegarreta avatar Mar 29 '25 00:03 jhlegarreta