account git

[fcomte]

Users can no more save the time that their git credential should be cache?

Can we add this here ?

[fcomte]

this value is store in vault with the secret : gitCredentialCacheDuration

[garronej]

We removed this field because we assumed 0 (infinity) would always be the preferred default.
Was there user complaints about it?
Anyway, sure, I can add it back in if you think it's relevant.

[fcomte]

0 is not working. There is no cache at the moment. But anyway I prefer that users can control this security feature

[garronej]

What's the correct value for infinity then?

[fcomte]

i don't know

[fcomte]

but infinity is very bad for security so I really don't like that

[garronej]

Considering we have IP protection enabled by default and a services password I though the git password was protected enough already... What do you see as default? 2 hours?

[fcomte]

The last default was no cache (0) I think it's a good default because it's the standard configuration of git.

[garronej]

Ok that's a good thing. To change a default I have to write a migration script...