InnerSourcePatterns icon indicating copy to clipboard operation
InnerSourcePatterns copied to clipboard

closes #181 add: definition of oss or iss project

Open chtompki opened this issue 5 years ago • 15 comments

For the sake of posterity:

  • OSS = Open Source Software
  • ISS = InnerSource Software

chtompki avatar Jun 25 '20 20:06 chtompki

I like the idea of writing down what aspects make InnerSource projects work. Two comments:

If possible, it would be great to formulate this pattern as a pattern. You can either look at the structure of the other patterns. Alternatively there's https://www.youtube.com/watch?v=mMPdG2O-W2Y that I believe explains the structure and the reasoning behind that structure very well.

I would refrain from including a definition of an Open Source project here. The Open Source definition is kept by another organisation: https://opensource.org/osd

Maybe a starting point for rephrasing the content that was proposed here: Try to think about phrasing the pattern as one that helps increase community appeal?

Also this pattern should be put into relation with https://github.com/InnerSourceCommons/InnerSourcePatterns/issues/116

MaineC avatar Jun 26 '20 09:06 MaineC

Good point. I didn’t know about that definition off hand. Should be able to get back to this later today.

chtompki avatar Jun 26 '20 09:06 chtompki

Hi @chtompki. Do you want any help? From the thread above it sounds like you were considering to describe the content that you already have as an InnerSource Pattern?

spier avatar Jul 28 '20 19:07 spier

Pardon me...I can try to get to it in the morning. Been a busy little while lately. Many thanks for the nudge :-)

chtompki avatar Jul 28 '20 19:07 chtompki

Working on this today.

chtompki avatar Aug 01 '20 12:08 chtompki

@MaineC - what do you think of my changes? Should we add a maturity model to this definitions section? I would think we might not, and instead create a maturity model that is separate referring to the definitions?

chtompki avatar Aug 01 '20 13:08 chtompki

Curious that the link checker failed. I just loaded all of the references just now in under 5s.

chtompki avatar Aug 01 '20 13:08 chtompki

The link checker fails with this error:

ERROR	definintion-of-oss-or-iss-project.md
		Stat definintion-of-oss-or-iss-project.md: no such file or directory

The link you created in the main README.md and the filename that you created don't match.

link: definintion-of-oss-or-iss-project.md filename: definintion-of-iss-project.md

spier avatar Aug 02 '20 08:08 spier

Quite happy to make changes...will take me some time to carve out the time to sort it out. Changes will work their way in, in the coming days.

chtompki avatar Aug 15 '20 17:08 chtompki

Pardon my being remiss here. My $job became quite overbearing towards the end of the summer there. I have have more time on my hands :-)

chtompki avatar Sep 29 '20 17:09 chtompki

Pardon my being remiss here. My $job became quite overbearing towards the end of the summer there. I have have more time on my hands :-)

Absolutely no problem, we all have jobs, lifes and this review isn't running away anytime soon. Happy to continue reviewing and merging eventually whenever you have time.

lenucksi avatar Oct 03 '20 10:10 lenucksi

Hi @chtompki just checking in here again, if you would have the time and energy to continue work on this PR/pattern?

spier avatar Dec 06 '20 11:12 spier

Am working on this now

chtompki avatar Dec 09 '20 16:12 chtompki

@chtompki let us know when you feel like you got to a good next version and want an other review, or help in any form.

spier avatar Dec 09 '20 21:12 spier

hi @chtompki. I am wondering whether you want to continue work on this PR/pattern in the near future? Otherwise this PR is at risk of running stale.

Also FYI there might be some overlap between what you are aiming to define here, and this pattern: https://github.com/InnerSourceCommons/InnerSourcePatterns/blob/main/patterns/1-initial/explicit-innersource-principles.md

Let us know how you want to proceed. And of course if you need any help, just ask :)

spier avatar Dec 14 '21 07:12 spier

@chtompki @MaineC wondering where this is at? Maybe something that we could try to finish as part of hacktoberfest?

Alternatively if you feel that you won't have time to work on this anymore, we can also close this PR, as I am suspecting that it would be a bit hard for somebody else to finish this PR?

spier avatar Oct 08 '22 20:10 spier

Closing this PR as stale now -- by all means re-open if still active.

robtuley avatar Nov 24 '22 20:11 robtuley