injective-ts icon indicating copy to clipboard operation
injective-ts copied to clipboard

Feat/add owallet

Open toandq2009 opened this issue 1 year ago • 2 comments

Greetings from the OWallet team! We would like to contribute by adding OWallet strategy support to wallet-ts. You can find more details about our team here.

This pull request delivers the following functionalities:

•	Allow users to seamlessly interact with Cosmos-based chains through the app
•	Provide features for fetching account addresses, signing, , and submitting transactions

Note: Currently, the feature only supports Cosmos addresses. Ethereum support will be implemented in the near future.

Summary by CodeRabbit

  • New Features

    • Introduced support for the OWallet, expanding wallet options for users.
    • Enhanced transaction broadcasting and signing capabilities for OWallet.
    • Added detection for OWallet installation and browser compatibility.
  • Bug Fixes

    • Improved error handling for wallet operations and transaction failures.
  • Documentation

    • Updated documentation to reflect new OWallet functionalities and integration.

toandq2009 avatar Sep 27 '24 05:09 toandq2009

Walkthrough

The changes introduce the OWallet functionality into the wallet-ts package, including the addition of a new dependency, @owallet/types. Various files have been updated to integrate the OWallet into existing wallet strategies, transaction handling, and utility functions. This includes the creation of new classes and methods specifically for OWallet, enhancing the wallet management capabilities within the Cosmos ecosystem.

Changes

File Path Change Summary
packages/wallet-ts/package.json Added new dependency: @owallet/types version 0.9.13.
packages/wallet-ts/src/broadcaster/MsgBroadcaster.ts Integrated OWallet into wallet handling logic, updated checks and exceptions related to Ledger.
packages/wallet-ts/src/strategies/cosmos-wallet-strategy/CosmosWalletStrategy.ts Added OWallet to supported wallets and updated createWallet function for instantiation.
packages/wallet-ts/src/strategies/cosmos-wallet-strategy/strategies/OWallet.ts Introduced OWallet class implementing wallet strategy with methods for transaction handling.
packages/wallet-ts/src/strategies/wallet-strategy/WalletStrategy.ts Added case for Wallet.OWallet in createStrategy function.
packages/wallet-ts/src/strategies/wallet-strategy/strategies/OWallet.ts Created OWallet class for Keplr wallet interactions, focusing on Cosmos transactions.
packages/wallet-ts/src/types/enums.ts Added new enum entry: OWallet = 'owallet'.
packages/wallet-ts/src/utils/wallets/cosmos/utils.ts Updated wallet detection functions to include OWallet.
packages/wallet-ts/src/utils/wallets/index.ts Added export statement for owallet module.
packages/wallet-ts/src/utils/wallets/owallet/index.ts Introduced new index.ts file to re-export owallet module contents.
packages/wallet-ts/src/utils/wallets/owallet/owallet.d.ts Extended global Window interface for OWalletWindow properties.
packages/wallet-ts/src/utils/wallets/owallet/owallet.ts Created OWalletBase class for wallet interactions, including methods for transactions and account management.

Possibly related PRs

  • #505: Involves updates to the package.json file but does not relate to the addition of the @owallet/types dependency or the integration of the OWallet functionality.

🐇 In the garden, hopping with glee,
New wallets bloom, as bright as can be!
OWallet joins the merry dance,
With transactions flowing, giving us a chance.
So let’s celebrate this joyful spree,
A world of wallets, wild and free! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 27 '24 05:09 coderabbitai[bot]

Hey, we are doing some refactors on the wallet-ts package and will ping you here once the refactor is done.

bangjelkoski avatar Oct 10 '24 11:10 bangjelkoski

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

socket-security[bot] avatar Oct 29 '24 07:10 socket-security[bot]

Hey there, OWallet support was implemented in our latest refactor of our wallet management.

You should be able to now use OWallet via the new wallet-cosmos package which can be found here

These packages are still brand new and haven't been fully tested yet, but you should be able to use and test OWallet by following the instructions in the README in the linked package.

billyjacoby avatar Nov 01 '24 11:11 billyjacoby