dynamic-cli icon indicating copy to clipboard operation
dynamic-cli copied to clipboard

Add xonsh shell in dynamic

Open GouravSardana opened this issue 4 years ago • 13 comments

We have to make autocomplete feature for dynamic. To make it work we need to create a xonsh shell. Still confused ? Ref to this - xonsh

How does it actually works?

When a user types dynamic. It will redirect to a different shell on the same terminal and we can use autocomplete in that shell because our normal terminal doesn't allow you to autocomplete.

Ref first 1 sec of GIF [When he type gitsome, Another shell got popup [still confused? Tried installing gitsome in local and type gitsome in terminal]]-

endgoal

Credit for xonsh - xonsh Credit for Gitsome - Gitsome

GouravSardana avatar Sep 30 '21 11:09 GouravSardana

Hi, I would like to work on this issue. Could you please give some head start? It would be helpful.

sudojarvis avatar Mar 02 '22 10:03 sudojarvis

Go ahead buddy @sudojarvis

GouravSardana avatar Mar 02 '22 10:03 GouravSardana

@GouravSardana gitsome uses xonsh shell. I have to do a similar thing right?

sudojarvis avatar Mar 03 '22 06:03 sudojarvis

Do we have to do it from scratch or we can merge it from xonsh.

sudojarvis avatar Mar 03 '22 06:03 sudojarvis

@sudojarvis That’s correct gitsome uses the xonsh shell. no no, you don’t have to create it from scratch just leverage the xonsh and try to replicate the flow from gitsome

GouravSardana avatar Mar 03 '22 06:03 GouravSardana

@GouravSardana could you please assign the issue to me under GSSOC'22.

sudojarvis avatar Mar 05 '22 09:03 sudojarvis

Np. Work on this issue. Don’t worry about assigning the issues. I’ll take care of that

GouravSardana avatar Mar 05 '22 10:03 GouravSardana

https://user-images.githubusercontent.com/75030755/156933413-3f2940af-45ff-4783-b723-f12a83604233.mp4

@GouravSardana Till now it is auto-completing, what I typed previously. But I have used code from gitsome. Is this fine?

sudojarvis avatar Mar 06 '22 16:03 sudojarvis

@sudojarvis Is this using XONSH ? I couldn't see this going to the xonsh terminal just like in gitsome.

  • If I type gitsome, It'll open up a new customize terminal where we can do autocomplete
  • Is this autocomplete based on our history or the argument which we have ?

GouravSardana avatar Mar 06 '22 16:03 GouravSardana

@sudojarvis Is this using XONSH ? I couldn't see this going to the xonsh terminal just like in git

  • If I type gitsome, It'll open up a new customize terminal where we can do autocomplete
  • Is this autocomplete based on our history or the argument which we have ?

@GouravSardana yes, to 1st two questions. And updated the video watch from 2:35.

sudojarvis avatar Mar 06 '22 17:03 sudojarvis

  • Is this autocomplete based on our history or the argument which we have ? based on our history

sudojarvis avatar Mar 06 '22 17:03 sudojarvis

Okay but i think this autocomplete should work based on both things. One is history and other is args. As of now, can you make a PR, I’ll review it locally and will give you suggestions accordingly

GouravSardana avatar Mar 06 '22 17:03 GouravSardana

@sudojarvis Any update ?

GouravSardana avatar Mar 07 '22 18:03 GouravSardana