Installer icon indicating copy to clipboard operation
Installer copied to clipboard

Handle invalid paths better

Open LeafHacker opened this issue 6 years ago • 5 comments
trafficstars

Currently the user can enter any string as a minecraft directory

This is fine, but we should ensure we are better able to handle this

LeafHacker avatar May 18 '19 18:05 LeafHacker

if it aint a directory we should put up a warning

also we need to check if they have the minecraft version installed and launched, just realized taht it doesnt have that either

are there any other sanity checks on what makes a valid minecraft directory? i guess launcher_profiles.json?

leijurv avatar May 18 '19 18:05 leijurv

Well, if they've not run the launcher before we may need to create launcher_profiles?

LeafHacker avatar May 18 '19 19:05 LeafHacker

Do they definitely need to have run the mc version before?

LeafHacker avatar May 18 '19 19:05 LeafHacker

Yes the definitely need to have run it (#33)

When you edit that JTextField it doesn't update the actual setting tho =(

leijurv avatar May 28 '19 20:05 leijurv

When you edit that JTextField it doesn't update the actual setting tho =(

My bad, atm you have to hit enter for it to update the setting. If we handle invalid stuff better we should probably listen on some typing event instead of ActionEvent.

LeafHacker avatar May 28 '19 21:05 LeafHacker