Installer icon indicating copy to clipboard operation
Installer copied to clipboard

“Install” button hidden when using custom optifine

Open Serial-Comma opened this issue 5 years ago • 3 comments
trafficstars

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Launch the installer'
  2. Click on 'Include Optifine? (Yes)'
  3. Click under "Optifine version" 'Custom'
  4. After selecting custom optifine version, install button is not clickable or visible anymore

Expected behavior A clear and concise description of what you expected to happen. I expected to be able to click on the install button Screenshots If applicable, add screenshots to help explain your problem. image Desktop (please complete the following information): Ubuntucinnamon, latest version of impact as of typing. Smartphone (please complete the following information): N/A Additional context N/A

Serial-Comma avatar Nov 08 '20 17:11 Serial-Comma

This is caused by GUI scaling/widget size being different on your platform/system theme. That combined with our fixed height window size.

IIRC @leijurv is keen on keeping the window a fixed size without allowing adjustment, however it may be possible to allow the window to either grow or scroll when widgets overflow...

MattSturgeon avatar Dec 18 '20 21:12 MattSturgeon

This is caused by [your] GUI scaling/widget size being different [...] combined with our fixed window height.

Yep

IIRC @leijurv is keen on keeping the window a fixed size

Thoughts @leijurv?

LeafHacker avatar Dec 18 '20 21:12 LeafHacker

I honestly don't remember why, that was a good 18 months ago haha.

We could definitely try making the window resizable, give that a shot. Sounds fine to me.

leijurv avatar Dec 19 '20 09:12 leijurv